Skip to content

[CI Failure Doctor] JS validation regression after PR #10125 - 43 tests failing #10137

Description

@github-actions

🏥 CI Failure Investigation - Run #21046376185

Summary

CRITICAL REGRESSION: JavaScript validation is completely broken after PR #10125. 43 tests failing, validation not rejecting invalid data.

Failure Details

  • Run: #21046376185
  • Commit: 5531197 (only docs changes)
  • Failed Job: js (43 test failures)
  • Severity: CRITICAL (security issue)

Timeline

20:51:37Z - PR #10125 merged
21:07:02Z - Commit 5531197 pushed
21:07:07Z - CI FAILED

Root Cause

PR #10125 broke validation in collect_ndjson_output.cjs. Tests expect validation errors, get empty arrays. INVALID DATA PASSING VALIDATION.

Test Failures

  • 36: collect_ndjson_output.test.cjs (validation broken)
  • 2: MCP server timeouts
  • 1: Missing error handling
  • 4: Go binary not found

Actions

  1. Investigate PR Fix JavaScript test failures: schema validation and missing template files #10125 validation changes
  2. Consider reverting
  3. Restore validation logic

Prevention

NEVER weaken validation to pass tests. Fix root cause, run full tests, verify CI.

AI generated by CI Failure Doctor

To add this workflow in your repository, run gh aw add githubnext/agentics/workflows/ci-doctor.md@ea350161ad5dcc9624cf510f134c6a9e39a6f94d. See usage guide.

Activity

  1. github-actions commented on Jan 15, 2026

    @github-actions
    ContributorAuthor

    🔄 Duplicate CI Failure Detected - Run #21046727156

    This investigation found another failure in the same js job 12.8 minutes after the original failure reported in this issue.

    Failure Details

    Analysis

    The js job continues to fail on main branch commits following the original failure. This indicates:

    1. Issue persists: The validation regression from PR Fix JavaScript test failures: schema validation and missing template files #10125 (documented in this issue) has not been fixed
    2. New commit affected: Dependabot's devalue bump PR (Bump devalue from 5.5.0 to 5.6.2 in /docs #10123) merged but CI still failing
    3. Blocking deployments: Main branch is in a broken state - every push to main will fail

    Files Modified in Failing Commit

    The dependabot PR modified:

    • actions/setup/js/package.json ✅ (added new file)
    • actions/setup/js/package-lock.json ✅ (updated dependencies)
    • docs/package.json (updated devalue)
    • docs/package-lock.json (updated devalue lock)

    Recommended Actions

    Priority 1 - Unblock Main:

    1. Review and merge fix for PR Fix JavaScript test failures: schema validation and missing template files #10125 validation regression (root cause)
    2. Verify all 43 tests pass locally before merging
    3. Consider reverting PR Fix JavaScript test failures: schema validation and missing template files #10125 if fix is not immediately available

    Priority 2 - Investigation:

    1. ⚠️ Cannot access logs - GitHub API returned 403 Forbidden when attempting to download job logs
    2. Need manual review of job logs to confirm if this is:
      • Same 43 test failures as #21046376185, OR
      • New failures introduced by devalue package bump, OR
      • Combination of both issues

    Investigation Data

    Full investigation saved to cache: /tmp/gh-aw/cache-memory/investigations/investigation-21046727156.json


    Conclusion: This appears to be a duplicate/continuation of the issue reported here. The js job remains broken on main branch and is failing on subsequent commits.

    🤖 Investigation by CI Failure Doctor

    See workflow run for complete investigation details.

    AI generated by CI Failure Doctor

  2. github-actions commented on Jan 15, 2026

    @github-actions
    ContributorAuthor

    🔄 Duplicate Failure Detected - Run #21046993463

    This CI run failed with the EXACT SAME ISSUE as reported in this issue.

    Run Details

    • Run: #21046993463
    • Commit: e171ce8
    • Author: dsyme
    • Timestamp: 2026-01-15 21:29:02 UTC
    • Failed Job: js

    Test Failure Summary

    43 tests failed - identical to the original report:

    Test File Failures Pattern
    collect_ndjson_output.test.cjs 36 Validation not rejecting invalid data
    safe_outputs_mcp_server_defaults.test.cjs 2 MCP server timeouts
    noop.test.cjs 1 Missing error handling
    mcp_logger.test.cjs 4 Go binary not found

    Key Error Pattern

    All validation tests are failing with the same signature:

    AssertionError: expected [] to have a length of 1 but got +0
    

    This confirms the validation logic is completely broken - tests expect validation errors but get empty arrays, meaning invalid data is passing validation.

    Impact

    This failure is blocking the main branch and represents an ongoing critical security issue. The regression from PR #10125 remains unresolved.

    Recommendation

    URGENT: This needs immediate attention as it's causing repeated CI failures on main branch commits.


    Investigation performed by CI Failure Doctor

    Saved to cache: /tmp/gh-aw/cache-memory/investigations/2026-01-15-run-21046993463.json

    AI generated by CI Failure Doctor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions