Skip to content

[plan] Fix missing needs: declarations in 4 workflow files (22 actionlint expression errors) #17669

Description

@github-actions

Objective

Fix 22 actionlint [expression] errors in 4 workflow markdown files by adding missing needs: job dependencies where needs.precompute.outputs.* or needs.check_ci_status.outputs.* are referenced.

Context

From Static Analysis Report discussion #17668 (2026-02-22 scan):

  • 22 expression errors across 4 workflows
  • Jobs reference needs.precompute.outputs.* or needs.check_ci_status.outputs.* in their env: blocks without declaring those upstream jobs in their needs: field
  • This causes actionlint type errors because the outputs object type is {} (empty) from actionlint's perspective

Affected Files

  • .github/workflows/bot-detection.md — 12 errors (3 jobs reference needs.precompute.outputs.action, issue_body, issue_number, issue_title)
  • .github/workflows/hourly-ci-cleaner.md — 6 errors (needs.precompute.outputs.* + needs.check_ci_status.outputs.*)
  • .github/workflows/release.md — 3 errors (needs.precompute.outputs.* in 1 job)
  • .github/workflows/issue-monster.md — 1 error (needs.precompute.outputs.*)

Required Fix

For each affected job that uses needs.precompute.outputs.*, add precompute to that job's needs: list. Similarly add check_ci_status where referenced.

Example:

Before:

agent:
  # no needs: declared
  env:
    GH_AW_NEEDS_PRECOMPUTE_OUTPUTS_ACTION: ${{ needs.precompute.outputs.action }}

After:

agent:
  needs: [precompute]
  env:
    GH_AW_NEEDS_PRECOMPUTE_OUTPUTS_ACTION: ${{ needs.precompute.outputs.action }}

Steps

  1. Open each affected .md file and inspect the jobs section in the YAML frontmatter
  2. For each job referencing needs.precompute.outputs.*, add precompute to needs: if not already present
  3. For each job referencing needs.check_ci_status.outputs.*, add check_ci_status to needs: if not already present
  4. Run make build && ./gh-aw compile .github/workflows/bot-detection.md (and the other 3 files) to recompile
  5. Verify the actionlint expression errors are gone: make recompile && actionlint .github/workflows/bot-detection.lock.yml (and others)

Acceptance Criteria

  • All 22 expression errors resolved in the 4 affected workflows
  • All 4 workflows still compile successfully (make recompile)
  • make agent-finish passes with no new errors

Generated by Plan Command for issue #discussion #17668

  • expires on Feb 24, 2026, 7:00 AM UTC

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions