Skip to content

Allowed expressions should allow simple defaults #19468

Closed

Description

@dsyme

A generated workflow used a nice pattern to embed defaults reliably:

- **Repository**: ${{ github.repository }}
- **Run ID**: ${{ github.run_id }}
- **Triggered by**: @${{ github.actor }}
- **Devices to test**: ${{ inputs.devices || 'mobile,tablet,desktop' }}
- **Docs directory**: ${{ inputs.docs_dir || 'docs' }}
- **Build command**: ${{ inputs.build_command || 'npm run build' }}
- **Serve command**: ${{ inputs.serve_command || 'npm run preview' }}
- **Server port**: ${{ inputs.server_port || '4321' }}
- **Working directory**: ${{ github.workspace }}

This seems valid to allow - a || b for two valid expressions including simple constants

Activity

  1. pelikhan commented on Mar 4, 2026

    @pelikhan
    Collaborator

    This should be allowed for expressions that are controlled by github.

  2. pelikhan commented on Mar 4, 2026

    @pelikhan
    Collaborator

    Add tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions