Contribution Check Report — PR #21222
| Field |
Value |
| PR |
#21222 |
| Title |
fix: label_command doesn't trigger when workflow also has slash_command |
| Author |
@Copilot |
| Verdict |
⚠️ Needs Focus |
| Quality |
needs-work |
| On-topic |
✅ yes |
| Follows process |
✅ yes |
| Focused |
❌ no |
| New deps |
✅ no |
| Has tests |
✅ yes |
| Lines changed |
135 |
| Existing labels |
(none) |
Checklist Breakdown
-
On-topic — yes. The fix targets check_command_position.cjs, a core action in the pre_activation gate that controls workflow dispatch. Fixing a silent skip when label_command and slash_command are combined is squarely within the project's scope.
-
Follows process — yes. The PR is authored by the Copilot coding agent, which is the prescribed contribution method for core team changes per CONTRIBUTING.md.
-
Focused — no. The PR bundles two distinct changes:
- The targeted bug fix in
actions/setup/js/check_command_position.cjs and its tests.
- Large modifications to
.github/workflows/smoke-call-workflow.lock.yml (99 lines), removing the entire create_issue tool block — with no corresponding change to the source smoke-call-workflow.md and no mention in the PR description.
-
New deps — no.
-
Has tests — yes. Three new test cases in check_command_position.test.cjs covering labeled events for issues, pull_request, and discussion.
-
Has description — yes. The PR body explains the bug clearly with a before/after code snippet.
-
Diff size — 135 lines total.
Reasoning
The lock file .github/workflows/smoke-call-workflow.lock.yml is an auto-generated artifact compiled from its corresponding .md source via make recompile. However, the source file smoke-call-workflow.md is not modified in this PR, which makes the lock file diff unexplained. The change removes create_issue tool configuration — a meaningful semantic change to the smoke workflow that has no bearing on the label_command bug fix. Even for auto-generated files, the absence of any explanation in the PR description and the large functional delta make this a focus concern.
Generated by Contribution Check · ◷
Contribution Check Report — PR #21222
@CopilotChecklist Breakdown
On-topic —
yes. The fix targetscheck_command_position.cjs, a core action in thepre_activationgate that controls workflow dispatch. Fixing a silent skip whenlabel_commandandslash_commandare combined is squarely within the project's scope.Follows process —
yes. The PR is authored by the Copilot coding agent, which is the prescribed contribution method for core team changes per CONTRIBUTING.md.Focused —
no. The PR bundles two distinct changes:actions/setup/js/check_command_position.cjsand its tests..github/workflows/smoke-call-workflow.lock.yml(99 lines), removing the entirecreate_issuetool block — with no corresponding change to the sourcesmoke-call-workflow.mdand no mention in the PR description.New deps —
no.Has tests —
yes. Three new test cases incheck_command_position.test.cjscovering labeled events forissues,pull_request, anddiscussion.Has description —
yes. The PR body explains the bug clearly with a before/after code snippet.Diff size — 135 lines total.
Reasoning
The lock file
.github/workflows/smoke-call-workflow.lock.ymlis an auto-generated artifact compiled from its corresponding.mdsource viamake recompile. However, the source filesmoke-call-workflow.mdis not modified in this PR, which makes the lock file diff unexplained. The change removescreate_issuetool configuration — a meaningful semantic change to the smoke workflow that has no bearing on thelabel_commandbug fix. Even for auto-generated files, the absence of any explanation in the PR description and the large functional delta make this a focus concern.