Skip to content

[plan] Add console formatting to pkg/workflow warning/error messages #21468

Closed as not planned

Description

@github-actions

Objective

Update pkg/workflow/claude_logs.go, pkg/workflow/cache.go, and pkg/workflow/mcp_renderer.go to use console.FormatWarningMessage() / console.FormatErrorMessage() instead of raw stderr writes.

Context

From the Terminal Stylist audit (discussion #21455), three files in pkg/workflow write raw warning/error strings directly to stderr without any console formatting. This results in inconsistent output styling compared to the rest of the CLI.

Files to Modify

  • pkg/workflow/claude_logs.go — 8 raw writes, no console.Format* usage
  • pkg/workflow/cache.go — 2 raw writes, no console.Format* usage
  • pkg/workflow/mcp_renderer.go — 1 raw write, no console.Format* usage

Approach

  1. In each file, import github.com/github/gh-aw/pkg/console
  2. Replace raw fmt.Fprintf(os.Stderr, "Warning: %s", ...) with fmt.Fprintln(os.Stderr, console.FormatWarningMessage(...))
  3. Replace raw error/failure messages with console.FormatErrorMessage(...)
  4. Use console.FormatInfoMessage() for informational messages

Acceptance Criteria

  • All warning messages in the three files use console.FormatWarningMessage()
  • All error messages use console.FormatErrorMessage()
  • No raw Warning: or Error: prefixed stderr writes remain
  • make fmt && make lint && make test-unit pass

Generated by Plan Command for issue #discussion #21455 · ◷

  • expires on Mar 19, 2026, 11:44 PM UTC

Activity

  1. github-actions commented on Mar 20, 2026

    @github-actions
    ContributorAuthor

    This issue was automatically closed because it expired on 2026-03-19T23:44:06.346Z.

    Closed by Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions