Skip to content

[plan] Fix dangerous GITHUB_ENV write in dev-hawk workflow (High severity) #25861

Closed as not planned

Description

@github-actions

Objective

Fix the High-severity github-env finding in the dev-hawk workflow reported by zizmor. Writing to $GITHUB_ENV with attacker-influenced content can inject environment variables that affect subsequent steps.

Context

The dev-hawk.lock.yml at line 1306 writes to $GITHUB_ENV with potentially attacker-controlled data. This can let an attacker override environment variables used by later steps in the same job.

Reference: Static Analysis Report - 2026-04-11

Approach

  1. Open .github/workflows/dev-hawk.md
  2. Locate the step that writes to $GITHUB_ENV (corresponds to lock file line 1306)
  3. Evaluate whether the value written is attacker-controlled (e.g., from issue/PR content, usernames, branch names)
  4. If the value is attacker-controlled, replace $GITHUB_ENV usage with either:
    • An env: block on the specific step(s) that need the value (preferred — limits scope)
    • A sanitization step before writing to $GITHUB_ENV
  5. Run make recompile to regenerate the lock file
  6. Run make agent-finish to validate

Steps

  1. Open .github/workflows/dev-hawk.md and find the $GITHUB_ENV write
  2. Trace where the written variable is consumed by later steps
  3. Determine if the source of the value is attacker-controlled
  4. Apply the appropriate fix (scoped env: block or sanitization)
  5. Recompile and validate

Acceptance Criteria

Generated by Plan Command for issue #25835 · ● 199.3K · ◷

  • expires on Apr 13, 2026, 11:54 PM UTC

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions