[lint-monster] function-length refactoring backlog refresh — 684 findings across pkg/workflow and pkg/cli #45033

Summary

Daily make golint-custom found a shared largefunc backlog that should be tracked as a single topic: function-length refactoring.

Current authoritative count from this lint run: 684 function-length findings.

Affected areas:

• pkg/workflow: 289 findings
• pkg/cli: 379 findings
• additional function-length findings outside those path buckets in the current diagnostics snapshot: 16

Representative diagnostics:

• pkg/workflow/maintenance_workflow_yaml.go:35: buildMaintenanceWorkflowYAML is 961 lines long
• pkg/workflow/frontmatter_extraction_yaml.go:131: commentOutProcessedFieldsInOnSection is 657 lines long
• pkg/workflow/compiler_main_job.go:26: buildMainJob is 420 lines long
• pkg/cli/audit_report_render.go:24: renderConsole is 310 lines long
• pkg/cli/add_workflow_resolution.go:66: ResolveWorkflows is 198 lines long
• pkg/cli/mcp_tools_privileged.go: 6 functions currently exceed the limit

Expected outcome:

• Reduce the shared largefunc backlog with focused extractions that preserve behavior and tests.
• Keep work sliced into reviewable refactors rather than broad rewrites.

Remediation checklist

• Work only on the assigned function-length slice; do not mix unrelated lint fixes.
• Prefer minimal, targeted helper extractions and file splits along responsibility boundaries.
• Preserve existing behavior and test coverage.
• Validate by running make golint-custom before finishing.
• Prefer reviewable slices over broad rewrites.

Suggested next slices

• pkg/workflow/maintenance_workflow_yaml.go (buildMaintenanceWorkflowYAML)
• pkg/workflow/frontmatter_extraction_yaml.go (commentOutProcessedFieldsInOnSection)
• pkg/workflow/compiler_main_job.go (buildMainJob)
• pkg/workflow/tool_description_enhancer.go (enhanceToolDescription)
• pkg/cli/audit_report_render.go (renderConsole)
• pkg/cli/mcp_tools_privileged.go (highest-density CLI hotspot in this run)

Duplicates linked/closed in this run: none.

Fused guidance for any assigned agent:

• Keep remediation scoped to this lint group only.
• Prefer minimal, targeted code edits.
• Validate fixes with make golint-custom.

Generated by 🧌 LintMonster

Generated by 🧌 LintMonster · 16.7 AIC · ⌖ 3.97 AIC · ⊞ 4.4K · ◷

• expires on Jul 18, 2026, 7:48 PM UTC-08:00