Description
pkg/cli/logs_models.go:358-359 types RunID any / RunNumber any on the aw_info.json-derived struct, while sibling structs in the same file type the equivalent field as int64 (:123, :280) or string (:329) — a real runtime ambiguity, not just a style nit. Root cause: ${{ github.run_id }} serializes as either a JSON number or a templated string depending on the producing step, so call sites scatter %v/fmt.Sprintf formatting to cope. Verified live at all cited lines.
Expected Impact
A single NumericID type with a custom UnmarshalJSON accepting both number and string forms (normalizing to int64) removes the scattered ad-hoc formatting/type-switching at every call site that reads RunID/RunNumber.
Suggested Agent
Copilot coding agent — add the NumericID type, wire it into logs_models.go, update call sites that currently type-switch or %v-format these fields.
Estimated Effort
Quick (1-2 hours)
Data Source
DeepReport analysis, 2026-08-21 cycle, sourced from discussion #54506 (Typist - Go Type Consistency Analysis), Untyped Usages Category 2. No existing open issue found covering this specific mixed-type field.
Generated by 🔬 Deep Report · agent · 186.6 AIC · ⌖ 14.7 AIC · ⊞ 11.9K · ◷
Description
pkg/cli/logs_models.go:358-359typesRunID any/RunNumber anyon theaw_info.json-derived struct, while sibling structs in the same file type the equivalent field asint64(:123,:280) orstring(:329) — a real runtime ambiguity, not just a style nit. Root cause:${{ github.run_id }}serializes as either a JSON number or a templated string depending on the producing step, so call sites scatter%v/fmt.Sprintfformatting to cope. Verified live at all cited lines.Expected Impact
A single
NumericIDtype with a customUnmarshalJSONaccepting both number and string forms (normalizing toint64) removes the scattered ad-hoc formatting/type-switching at every call site that readsRunID/RunNumber.Suggested Agent
Copilot coding agent — add the
NumericIDtype, wire it intologs_models.go, update call sites that currently type-switch or%v-format these fields.Estimated Effort
Quick (1-2 hours)
Data Source
DeepReport analysis, 2026-08-21 cycle, sourced from discussion #54506 (Typist - Go Type Consistency Analysis), Untyped Usages Category 2. No existing open issue found covering this specific mixed-type field.