Skip to content

Replace hard-coded activation symlink path literals with named/shared path constants #44177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Jul 8, 2026
Merged

Replace hard-coded activation symlink path literals with named/shared path constants #44177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f41a4f
Initial plan
Copilot Jul 8, 2026
db838bc
Use constants for activation symlink candidate paths
Copilot Jul 8, 2026
db6db19
Add named activation symlink path variables
Copilot Jul 8, 2026
f0076e8
refactor: convert activation symlink paths to const using GithubDir p…
Copilot Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pkg/workflow/compiler_activation_job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ import (

var compilerActivationJobLog = logger.New("workflow:compiler_activation_job")

const (
activationSymlinkAgentDir = constants.GithubDir + "agents"
activationSymlinkSkillDir = constants.GithubDir + "skills"
activationSymlinkPromptDir = constants.GithubDir + "prompts"
)

var activationMetadataTriggerFields = map[string]struct{}{
"reaction": {},
"status-comment": {},
Expand Down Expand Up @@ -557,9 +563,9 @@ func resolveSymlinkExtraPaths(repoRoot string, extraPaths []string) []string {
return extraPaths
}
candidates := []string{
".github/agents",
".github/skills",
".github/prompts",
activationSymlinkAgentDir,
activationSymlinkSkillDir,
activationSymlinkPromptDir,
}
existing := make(map[string]struct{}, len(extraPaths))
for _, p := range extraPaths {
Expand Down
24 changes: 24 additions & 0 deletions pkg/workflow/compiler_activation_job_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,6 +1159,30 @@ func TestResolveSymlinkExtraPaths(t *testing.T) {
assert.Contains(t, result, ".ai/agents", "symlink target should be appended")
})

t.Run("symlink .github/skills resolved to inner path", func(t *testing.T) {
dir := t.TempDir()
require.NoError(t, os.MkdirAll(filepath.Join(dir, ".ai", "skills"), 0o755))
require.NoError(t, os.MkdirAll(filepath.Join(dir, ".github"), 0o755))
if err := os.Symlink(filepath.Join("..", ".ai", "skills"), filepath.Join(dir, ".github", "skills")); err != nil {
t.Skipf("symlinks not supported: %v", err)
}

result := resolveSymlinkExtraPaths(dir, nil)
assert.Contains(t, result, ".ai/skills", "symlink target should be appended")
})

t.Run("symlink .github/prompts resolved to inner path", func(t *testing.T) {
dir := t.TempDir()
require.NoError(t, os.MkdirAll(filepath.Join(dir, ".ai", "prompts"), 0o755))
require.NoError(t, os.MkdirAll(filepath.Join(dir, ".github"), 0o755))
if err := os.Symlink(filepath.Join("..", ".ai", "prompts"), filepath.Join(dir, ".github", "prompts")); err != nil {
t.Skipf("symlinks not supported: %v", err)
}

result := resolveSymlinkExtraPaths(dir, nil)
assert.Contains(t, result, ".ai/prompts", "symlink target should be appended")
})

t.Run("non-symlink .github/agents produces no extra entry", func(t *testing.T) {
dir := t.TempDir()
require.NoError(t, os.MkdirAll(filepath.Join(dir, ".github", "agents"), 0o755))
Expand Down
Loading