Align mcp/secrets help subcommand wording and add consistency guardrails - #51096
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix conflicting descriptions in
Align Aug 7, 2026
gh aw secrets help outputmcp/secrets help subcommand wording and add consistency guardrails
pelikhan
marked this pull request as ready for review
August 7, 2026 16:40
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns hand-written CLI subcommand listings with Cobra-generated descriptions and adds regression coverage.
Changes:
- Synchronizes
secrets bootstrapandmcp list-toolshelp wording. - Tests both listings against their Cobra
Shortdescriptions. - Refreshes the generated Cursor smoke workflow.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/secrets_command.go |
Aligns bootstrap help text. |
pkg/cli/mcp.go |
Aligns list-tools help text. |
pkg/cli/cli_consistency_help_test.go |
Adds consistency assertions. |
.github/workflows/smoke-cursor.lock.yml |
Refreshes generated workflow output. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI help output had drift between hand-written
Available subcommandsprose and Cobra-generatedAvailable Commandsentries, specifically forgh aw secrets(bootstrap) andgh aw mcp(list-tools). This change removes the wording split and adds a focused test to keep those descriptions in sync.Help text alignment
/pkg/cli/secrets_command.goprose entry forbootstrapto match the subcommandShorttext exactly./pkg/cli/mcp.goprose entry forlist-toolsto match the subcommandShorttext exactly.Consistency regression coverage
TestSubcommandListingsMatchCobraShortDescriptionsin/pkg/cli/cli_consistency_help_test.go.NewSecretsCommand().LongandNewMCPCommand().Longcontain bullet entries derived from the actual CobraShortdescriptions forbootstrapandlist-tools.