Dedupe RepositoryFeatures build-tag mirror struct; document raw-ANSI exception in console

[Copilot]

Two low-urgency cleanups from a deep-report audit: the RepositoryFeatures struct was byte-identical across the native and WASM build-tag variants with no mechanism to keep them in sync, and pkg/console/terminal.go used raw ANSI escapes without explaining why it deviates from the Lipgloss styling used elsewhere in the package.

Dedupe RepositoryFeatures

• Extracted the struct into a new build-tag-free file, pkg/workflow/repository_features.go, shared by both variants:

// pkg/workflow/repository_features.go (no build tags)
type RepositoryFeatures struct {
	HasDiscussions bool
	HasIssues      bool
}

• Removed the duplicate definitions from repository_features_validation.go (!js && !wasm) and repository_features_validation_wasm.go (js || wasm), so both variants now compile against a single definition and can't drift apart if a field is added later.

Document raw-ANSI exception

• Added a comment above the ANSI constants in pkg/console/terminal.go noting that clear-screen/clear-line escape sequences are an intentional exception, since Lipgloss has no equivalent for cursor/screen-control operations.

• Fixes [deep-report] Dedupe build-tag mirror structs and document raw-ANSI exception in console package #53998

---

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 23.6 AIC · ⌖ 8.21 AIC · ⊞ 9.3K · ◷
_{Comment /souschef to run again}

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

[github-actions]

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the implementation label and has only 18 new lines of code in business logic directories (threshold: 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

[github-actions]

✅ Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped.

🧪 Test quality analysis by Test Quality Sentinel

[github-actions]

❌ Ponytail Reviewer failed. Please review the logs for details.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by Ponytail Reviewer for #54379

[github-actions]

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

[github-actions]

Clean deduplication — moving RepositoryFeatures to a build-tag-free file is the right pattern for preventing native/WASM field drift, and the console comment accurately explains the raw-ANSI exception. No issues found.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 13.4 AIC · ⌖ 8.76 AIC · ⊞ 5.7K

[Copilot]

Pull request overview

Deduplicates RepositoryFeatures across native/WASM builds and documents intentional raw ANSI terminal controls.

Changes:

• Moves RepositoryFeatures into a shared file.
• Removes build-specific duplicate definitions.
• Documents the Lipgloss exception.

Show a summary per file

File	Description
pkg/workflow/repository_features.go	Adds the shared struct definition.
pkg/workflow/repository_features_validation.go	Removes the native duplicate.
pkg/workflow/repository_features_validation_wasm.go	Removes the WASM duplicate.
pkg/console/terminal.go	Explains raw ANSI usage.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 4/4 changed files
• Comments generated: 1
• Review effort level: Balanced

[github-actions]

Comment Memory

reviewed_at: 2026-08-21T00:00:00Z
review_event: COMMENT
top_themes:
  - no actionable issues in changed lines
  - deduped shared struct across build variants
  - clarified raw ANSI exception comment
files_reviewed:
  - pkg/console/terminal.go
  - pkg/workflow/repository_features.go
  - pkg/workflow/repository_features_validation.go
  - pkg/workflow/repository_features_validation_wasm.go
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 2.31 AIC · ⌖ 6.83 AIC · ⊞ 4.6K · ◷
_{Comment /review to run again}

[github-actions]

Verdict

Non-blocking cleanup only; the changes are mechanical deduplication plus documentation, and I did not find an actionable correctness or performance regression in the changed lines.

Highlights

• RepositoryFeatures is now defined once for both build variants, which reduces drift risk instead of increasing it.
• The ANSI comment in pkg/console/terminal.go is explanatory only and does not alter behavior.
• I found no missing tests or edge cases that are newly introduced by this patch.

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 2.31 AIC · ⌖ 6.83 AIC · ⊞ 4.6K
_{Comment /review to run again}

[github-actions]

Skills-Based Review 🧠

Applied /codebase-design — changes approved.

📋 Key Themes & Highlights

Key Themes

• Single source of truth for RepositoryFeatures: extracting the struct to a build-tag-free file is a textbook deep-module improvement — the interface (struct definition) is now centralised, and both build variants compile against it without any risk of field drift.
• Documentation of intentional deviation: the comment in terminal.go clearly explains the raw-ANSI exception — exactly the kind of in-place rationale that makes the codebase navigable for future contributors.

Positive Highlights

• ✅ New file comment accurately describes the purpose and the WASM field-population caveat.
• ✅ No behaviour change; purely structural, low-risk.
• ✅ No new tests needed — struct definitions and comment additions don't require unit tests.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 13.7 AIC · ⌖ 9.84 AIC · ⊞ 7.8K
_{Comment /matt to run again}

[gh-aw-bot]

@copilot Quick triage nudge for PR #54379.

• Failed checks to investigate:
  • agent: https://github.com/github/gh-aw/actions/runs/32431743603/job/96624828240
  • lint-go: https://github.com/github/gh-aw/actions/runs/32430606623/job/96624972923
• I also requested a branch refresh attempt for this PR.
• Please address the failing checks, refresh branch state if needed, and run the pr-finisher skill with a concise summary.

Run: https://github.com/github/gh-aw/actions/runs/32432532165

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 23.6 AIC · ⌖ 8.21 AIC · ⊞ 9.3K · ◷
_{Comment /souschef to run again}

[github-actions]

🔍 PR Triage

Category: refactor · Risk: low · Priority: low

Score: 41/100 (impact 15/50 + urgency 10/30 + quality 16/20)

Recommended action: batch_review
Batch: chore-refactor-small

Small internal dedupe + doc comment. CI passing. Low risk cleanup.

_{Automated triage — run 32432526976}

Generated by 🔧 PR Triage Agent · auto · 63.7 AIC · ⌖ 4.49 AIC · ⊞ 8.3K · ◷

[Copilot]

@copilot Quick triage nudge for PR #54379.

• Failed checks to investigate:...

Addressed in 34c8f37: updated pkg/workflow/README.md for the moved RepositoryFeatures symbol and fixed the changed-file errormessage lint findings in repository_features_validation.go. Local validation passed: targeted tests, custom lint, make lint, make test-unit, make recompile, and make agent-report-progress. make test initially hit transient unrelated pkg/cli failures; rerunning the failing completion tests and full pkg/cli package passed. CI is stale after the agent push and needs a human re-trigger.

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.87.4