Repository navigation
[WIP] Fix failing GitHub Actions job update - #61938
Conversation
…o compile Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
Great work on tackling the update job failure! 🚀 This PR shows focused fixes with test coverage: ✅ Checklist passed:
The PR is currently in draft status and looks ready for code review once finalized. No blockers identified.
|
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Backup read failures must stop the update to guarantee rollback remains possible.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds rollback protection when an upstream workflow update fails compilation.
Changes:
- Saves and restores the original workflow content on compile failure.
- Adds regression coverage for an invalid upstream dispatch target.
| File | Description |
|---|---|
pkg/cli/update_workflows.go |
Restores workflow content after failed compilation. |
pkg/cli/update_command_test.go |
Tests restoration after an invalid update. |
| originalContent, readOriginalErr := os.ReadFile(wf.Path) | ||
| hadOriginalContent := readOriginalErr == nil |
There was a problem hiding this comment.
Fixed in 64e33aa: backup read failures now abort before any write, and TestUpdateWorkflow_BackupReadFailureStopsUpdate verifies the workflow is not created or overwritten.
There was a problem hiding this comment.
This is already fixed on HEAD (64e33aa): updateWorkflow now returns an error and aborts before any write when the backup read fails, and TestUpdateWorkflow_BackupReadFailureStopsUpdate covers it. The PR's current head commit is 64e33aac9a4e4771aa0c2870ac6679e4a29883ba, so the fix is visible on the latest commit.
|
@copilot This PR still needs forward progress before a maintainer can merge it. Please address the unresolved Copilot review feedback and then run the Unresolved review follow-up:
I also requested a branch refresh for this PR. Failed checks: none currently; focus on the review finding above and hand back once updated. Run: https://github.com/github/gh-aw/actions/runs/35445378807 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Addressed the review in |
|
@copilot This PR still needs forward progress before a maintainer can merge it. Please resolve the remaining Copilot review thread at #61938 (comment), ensure the reviewer can see the fix on the latest head commit, and then run the I also requested a branch refresh for this PR. Run: https://github.com/github/gh-aw/actions/runs/35446452574 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
|
🎉 This pull request is included in a new release. Release: |

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.
Run: https://github.com/github/gh-aw/actions/runs/35445378807
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
hub.lumenfield.workTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
hub.lumenfield.workTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.