Skip to content

Allow two noop calls by default - #64031

Merged
pelikhan merged 7 commits into
mainfrom
copilot/make-noop-more-lenient
Sep 28, 2026
Merged

pelikhan merged 7 commits into
mainfrom
copilot/make-noop-more-lenient

Conversation

Copilot AI commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

The default single-call noop budget is too strict because an agent’s first call is often a probe. Increase the default to two calls while preserving explicit max overrides.

Changes

  • Raise implicit and explicit noop defaults from 1 to 2.
  • Align runtime validation and workflow schema metadata.
  • Update tests, reference documentation, and generated workflow locks.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 31.3 AIC · ⌖ 8.67 AIC · ⊞ 9.2K · ◷
Comment /souschef to run again

Copilot AI and others added 2 commits September 28, 2026 14:45
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Make noop accept two calls by default Allow two noop calls by default Sep 28, 2026
Copilot AI requested a review from pelikhan September 28, 2026 14:57
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot also detect probing requests and ignore

@pelikhan
pelikhan marked this pull request as ready for review September 28, 2026 15:03
Copilot AI balanced review requested due to automatic review settings September 28, 2026 15:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Compiler, runtime, schema, documentation, tests, and generated artifacts consistently apply the new default while retaining explicit overrides.

Review effort: Balanced
Findings: None

What changed in this PR

Raises the default noop budget from one to two calls, allowing a probe followed by a final response while preserving explicit overrides.

Changes:

  • Updates compiler, runtime validation, and schema defaults.
  • Adds Go and JavaScript regression coverage.
  • Refreshes documentation and generated workflow locks.
File Description
pkg/​workflow/​safe_outputs_validation_config.go Sets runtime default to two.
pkg/​workflow/​safe_outputs_config_extraction.go Updates implicit noop configuration.
pkg/​workflow/​safe_output_validation_config_test.go Tests validation default.
pkg/​workflow/​noop.go Updates explicit noop parsing defaults.
pkg/​workflow/​noop_test.go Updates parser expectations.
pkg/​workflow/​maintenance_workflow_cron_test.go Verifies implicit noop budget.
pkg/​parser/​schemas/​main_workflow_schema.json Updates schema metadata and defaults.
docs/​src/​content/​docs/​reference/​safe-outputs.md Documents the new limit.
docs/​src/​content/​docs/​reference/​frontmatter-full.md Updates generated frontmatter reference.
actions/​setup/​js/​safe_output_type_validator.test.cjs Tests JavaScript runtime validation.
.github/​workflows/​windows.lock.yml Regenerates noop runtime settings.
.github/​workflows/​windows-grower.lock.yml Regenerates noop runtime settings.
.github/​workflows/​weekly-network-domains-audit.lock.yml Regenerates noop runtime settings.
.github/​workflows/​video-analyzer.lock.yml Regenerates noop runtime settings.
.github/​workflows/​typist.lock.yml Regenerates noop runtime settings.
.github/​workflows/​test-quality-sentinel.lock.yml Regenerates noop runtime settings.
.github/​workflows/​super-linter.lock.yml Regenerates noop runtime settings.
.github/​workflows/​sub-issue-closer.lock.yml Regenerates noop runtime settings.
.github/​workflows/​stale-pr-cleanup.lock.yml Regenerates noop runtime settings.
.github/​workflows/​squad-plan.lock.yml Regenerates noop runtime settings.
.github/​workflows/​smoke-copilot-auto.lock.yml Regenerates noop runtime settings.
.github/​workflows/​skillet.lock.yml Regenerates noop runtime settings.
.github/​workflows/​sighthound-security-scan.lock.yml Regenerates noop runtime settings.
.github/​workflows/​scout.lock.yml Regenerates noop runtime settings.
.github/​workflows/​safe-output-health.lock.yml Regenerates noop runtime settings.
.github/​workflows/​repo-tree-map.lock.yml Regenerates noop runtime settings.
.github/​workflows/​release.lock.yml Regenerates noop runtime settings.
.github/​workflows/​refactoring-cadence.lock.yml Regenerates noop runtime settings.
.github/​workflows/​pr-description-caveman.lock.yml Regenerates noop runtime settings.
.github/​workflows/​pdf-summary.lock.yml Regenerates noop runtime settings.
.github/​workflows/​objective-impact-report.lock.yml Regenerates noop runtime settings.
.github/​workflows/​lockfile-stats.lock.yml Regenerates noop runtime settings.
.github/​workflows/​gpclean.lock.yml Regenerates noop runtime settings.
.github/​workflows/​go-pattern-detector.lock.yml Regenerates noop runtime settings.
.github/​workflows/​front-page-copy-guard.lock.yml Regenerates noop runtime settings.
.github/​workflows/​feature-grower.lock.yml Regenerates noop runtime settings.
.github/​workflows/​example-workflow-analyzer.lock.yml Regenerates noop runtime settings.
.github/​workflows/​example-failure-category-filter.lock.yml Regenerates noop runtime settings.
.github/​workflows/​draft-pr-cleanup.lock.yml Regenerates noop runtime settings.
.github/​workflows/​dev.lock.yml Regenerates noop runtime settings.
.github/​workflows/​dev-hawk.lock.yml Regenerates noop runtime settings.
.github/​workflows/​designer-drift-audit.lock.yml Regenerates noop runtime settings.
.github/​workflows/​deployment-incident-monitor.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-windows-terminal-integration-builder.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-team-status.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-semgrep-scan.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-observability-report.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-model-resolution.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-max-ai-credits-test.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-grader-audit.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-github-docs-seo-optimizer.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-file-diet.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-fact.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-credit-limit-test.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-choice-test.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-cache-strategy-analyzer.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-assign-issue-to-user.lock.yml Regenerates noop runtime settings.
.github/​workflows/​daily-action-setup-security-audit.lock.yml Regenerates noop runtime settings.
.github/​workflows/​copilot-pr-merged-report.lock.yml Regenerates noop runtime settings.
.github/​workflows/​commit-changes-analyzer.lock.yml Regenerates noop runtime settings.
.github/​workflows/​cli-consistency-checker.lock.yml Regenerates noop runtime settings.
.github/​workflows/​blog-auditor.lock.yml Regenerates noop runtime settings.
.github/​workflows/​archie.lock.yml Regenerates noop runtime settings.
.github/​workflows/​agent-persona-explorer.lock.yml Regenerates noop runtime settings.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

pr-sous-chef
@copilot Please address the latest maintainer follow-up on this PR, update the implementation if needed, and then run the pr-finisher skill before handing back for review.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 31.3 AIC · ⌖ 8.67 AIC · ⊞ 9.2K · ◷
Comment /souschef to run again

Copilot AI and others added 3 commits September 28, 2026 16:20
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

@copilot also detect probing requests and ignore

Probing noop calls are now detected and ignored end to end:

  • MCP invocation time: a noop whose message is an obvious placeholder (test, probe, placeholder, dummy, todo, …) is dropped — not written to the safe-outputs file and not counted against the noop budget. This also prevents a probe from tripping the harness pre-flight "noop already written" skip.
  • Ingestion time: collect_ndjson_output applies the same filter as defence in depth for direct NDJSON writes.

Detection reuses the existing TRIVIAL_PROBE_VALUES set in intent_probe.cjs. Covered by unit tests in safe_outputs_handlers.test.cjs and collect_ndjson_output.test.cjs, and documented in docs/src/content/docs/reference/safe-outputs.md.

@github-actions

Copy link
Copy Markdown
Contributor

Great work! 🎉 This PR looks ready for review. The change to raise default noop budgets from 1 to 2 is well-scoped and includes comprehensive test updates across 307 files, demonstrating thorough validation of the refactor. The PR description clearly articulates the rationale (first call is often a probe) and the implementation strategy (preserving explicit max overrides).

Generated by ✅ Contribution Check · copilot · auto · 49.4 AIC · ⌖ 8.07 AIC · ⊞ 9.1K · ◷

@pelikhan
pelikhan merged commit 5260b72 into main Sep 28, 2026
45 checks passed
@pelikhan
pelikhan deleted the copilot/make-noop-more-lenient branch September 28, 2026 17:12
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.90.0

github-actions Bot added a commit that referenced this pull request Sep 29, 2026
Document two schema fields added after prior v0.89.21 sync passes: noop's
`max` field (default now 2, from #64031) and custom safe-outputs jobs'
`artifacts` field for declaring extra agent-written paths (#63017).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants