Skip to content

Fix clean-main unit test failures - #65864

Merged
dsyme merged 2 commits into
mainfrom
copilot/fix-clean-main-tests
Oct 5, 2026
Merged

dsyme merged 2 commits into
mainfrom
copilot/fix-clean-main-tests

Conversation

@dsyme

@dsyme dsyme commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • isolate the workflow-log timeout test from live GitHub rate-limit calls
  • align scanner-image specs and documentation with digest-pinned constants
  • allow valid expressions in concurrency queue schema validation

Validation

  • make agent-report-progress
  • targeted failing tests reproduced and passed after the fixes

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 5, 2026 13:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Existing concurrency documentation still incorrectly states that queue values must be literals.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Fixes clean-main unit test failures by isolating network-dependent tests and aligning validation specifications.

Changes:

  • Stubs rate-limit calls in the timeout test.
  • Synchronizes scanner image documentation and tests.
  • Permits expressions in concurrency queue schema validation.
File Description
pkg/​workflow/​schemas/​github-workflow.json Allows queue expressions.
pkg/​cli/​spec_test.go Updates expected scanner images.
pkg/​cli/​README.md Documents digest-pinned images.
pkg/​cli/​context_cancellation_test.go Removes live rate-limit dependencies.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot address the following outstanding work in one pass:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.
  2. Review (pkg/workflow/schemas/github-workflow.json:52): Allowing queue expressions here leaves the documented contract contradictory: docs/src/content/docs/reference/concurrency.md:90 and pkg/workflow/concurrency.go:42-44 still state that GitHub Actions requires a literal queue value, while TestConcurrencyQueueSchemaValidation now accepts the exact conditional form. Update those statements so users are not told valid syntax is unsupported; also clarify whether mixed command/PR groups should continue omitting queue or emit the conditional value. - Fix clean-main unit test failures #65864 (comment)

Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI.

Sous-chef head: 8841db5
Sous-chef work: 7ffafbc02241fd73b27d3b0318c3b8c69190312c43387225c430abc253b6fdf7
Sous-chef state: 0fc02bc63be0d9554271f964f54bccd75361b66e503abdd6582962a8404edbdc

Generated by 👨‍🍳 PR Sous Chef · pi · haiku45 · 3.32 AIC · ⌖ 8.59 AIC · ⊞ 3.2K · ◷
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
@dsyme
dsyme merged commit b51fe35 into main Oct 5, 2026
29 checks passed
@dsyme
dsyme deleted the copilot/fix-clean-main-tests branch October 5, 2026 14:15
Copilot AI requested a review from gh-aw-bot October 5, 2026 14:17
Copilot stopped work on behalf of gh-aw-bot due to an error October 5, 2026 14:17
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.91.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants