Trust repo-memory ledgers in the daily AIC guardrail by Copilot · Pull Request #65879 · github/gh-aw

Copilot · 2026-10-05T14:51:53Z

Daily AIC guardrails blocked both affected scheduled workflows because they treated repo-memory ledgers as untrusted, despite the ledger being cloned before activation.

Trust provenance: The compiler marks repo-memory trusted only for the guardrail step that follows the required clone.
Preserve opt-in: Ledgers without that signal remain blocked unless the explicit insecure override is enabled; its default remains false.
Regression coverage: Verify normal ledger-writer output is accepted and the clone precedes guardrail evaluation.

const trustedLedger = process.env.GH_AW_DAILY_AIC_REPO_MEMORY_TRUSTED === "true";
const allowInsecureLedger = process.env.GH_AW_ALLOW_INSECURE_REPO_MEMORY_AIC === "true";

if (!trustedLedger && !allowInsecureLedger) {
  // Fail closed
}

Fixes [AW Top 10] 10 Resolve untrusted AIC ledger blocking daily workflows #65775

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Copilot review overview

🟡 Changes recommended

Clone failures can produce an empty directory that is incorrectly marked trusted, allowing the guardrail to fail open.

Review effort: Balanced
Findings: 1

Open (1)

Fail closed when repository clone fails · New

What changed in this PR

Allows daily AIC guardrails to trust repo-memory ledgers cloned during activation while retaining the insecure opt-in fallback.

Changes:

Adds compiler-generated ledger trust provenance.
Updates guardrail trust handling.
Adds regression and workflow-generation coverage.

File	Description
`pkg/workflow/compiler_activation_daily_aic.go`	Emits the trust signal.
`pkg/workflow/daily_aic_workflow_guardrail_test.go`	Verifies trust signal and step ordering.
`actions/setup/js/check_daily_aic_workflow_guardrail.cjs`	Accepts trusted ledgers.
`actions/setup/js/check_daily_aic_workflow_guardrail.test.cjs`	Tests writer-produced trusted ledgers.
`.github/workflows/daily-community-attribution.lock.yml`	Regenerates workflow with trust signal.
`.github/workflows/daily-code-metrics.lock.yml`	Regenerates workflow with trust signal.
`.github/workflows/daily-cli-performance.lock.yml`	Regenerates workflow with trust signal.

Copilot · 2026-10-05T16:59:19Z

 	}
 	if data.MaxDailyAICBackend == maxDailyAICBackendRepoMemory {
-		steps = append(steps, "          GH_AW_ALLOW_INSECURE_REPO_MEMORY_AIC: ${{ vars.GH_AW_ALLOW_INSECURE_REPO_MEMORY_AIC || 'false' }}\n")
+		steps = append(steps, "          GH_AW_DAILY_AIC_REPO_MEMORY_TRUSTED: \"true\"\n          GH_AW_ALLOW_INSECURE_REPO_MEMORY_AIC: ${{ vars.GH_AW_ALLOW_INSECURE_REPO_MEMORY_AIC || 'false' }}\n")


Fixed in f48f8b3: the clone step verifies branch existence with authenticated git ls-remote; only a confirmed missing branch falls back to an orphan, while transport, authentication, and clone failures exit nonzero. The guardrail trusts only a reported successful clone.

github-actions · 2026-10-05T15:39:37Z

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-10-05T15:39:38Z

✅ Ponytail Reviewer completed successfully!

Lean already. Ship.

Generated by Ponytail Reviewer for #65879

github-actions · 2026-10-05T15:39:42Z

🔍 Design Decision Gate 🏗️ is checking for design decision records on this pull request...

github-actions · 2026-10-05T15:39:42Z

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-10-05T15:39:43Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-10-05T15:45:20Z

Comment Memory

Peek at saved memory (pr-code-quality-reviewer)

reviewed_at: 2026-10-05T15:41:22Z
review_event: REQUEST_CHANGES
top_themes:
  - repo-memory trust is not tied to successful authenticated clone provenance
files_reviewed:
  - .github/workflows/daily-cli-performance.lock.yml
  - .github/workflows/daily-code-metrics.lock.yml
  - .github/workflows/daily-community-attribution.lock.yml
  - actions/setup/js/check_daily_aic_workflow_guardrail.cjs
  - actions/setup/js/check_daily_aic_workflow_guardrail.test.cjs
  - pkg/workflow/compiler_activation_daily_aic.go
  - pkg/workflow/daily_aic_workflow_guardrail_test.go
comment_count: 0

Note

This comment is managed by comment memory.

Expand the saved memory block to view or edit the persistent context for this thread.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 40.7 AIC · ⌖ 5.28 AIC · ⊞ 19.6K · ◷
_{Comment /review to run again}

github-actions

Request changes

The repo-memory trust bit is still disconnected from actual clone success, so a token/network/server failure can leave an empty or orphan ledger while the guardrail accepts it as trusted and undercounts prior runs.

Why this is still blocking

buildActivationDailyAICGuardrailStep sets GH_AW_DAILY_AIC_REPO_MEMORY_TRUSTED: "true" for every repo-memory workflow up front, but clone_repo_memory_branch.sh intentionally treats any git clone failure as recoverable and falls back to creating an orphan repo or empty directory. That means check_daily_aic_workflow_guardrail.cjs cannot distinguish verified branch clone success from local empty-state fallback, so the workflow can proceed under budget even when the historical ledger was never authenticated.

I am not adding another inline comment because there is already an open thread on the exact changed line, but that issue remains merge-blocking until trust is derived from a positive clone-success signal instead of compile-time configuration.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 40.7 AIC · ⌖ 5.28 AIC · ⊞ 19.6K
_{Comment /review to run again}

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs — requesting changes on an unguarded trust signal.

📋 Key Themes & Highlights

Key Themes

Root cause only partially addressed: the PR's goal is "trust the ledger only after a verified clone," but the generated GH_AW_DAILY_AIC_REPO_MEMORY_TRUSTED: "true" is unconditional — it does not actually check that the clone step succeeded with real data vs. silently falling back to an orphan branch on any clone failure (network, token, server errors). This is the same concern already raised by the existing automated review comment on pkg/workflow/compiler_activation_daily_aic.go:144; my inline comment extends it with a concrete implementation path (step output + if: gate, following the existing pattern in cache_memory.go:274).
Regression test asymmetry: the new JS test (check_daily_aic_workflow_guardrail.test.cjs) and Go test (daily_aic_workflow_guardrail_test.go) both verify the happy path (trusted ledger accepted, clone precedes guardrail) but neither exercises the failure path (clone fails → ledger should remain untrusted). Given this PR's entire purpose is correcting trust semantics, a negative test is the most valuable missing coverage.

Positive Highlights

✅ Compile-time coupling is solid: maxDailyAICBackendRepoMemory always requires tools.repo-memory (daily_aic_workflow.go:284), so the clone step and the trust env var can never be emitted independently of each other.
✅ Step ordering is correctly verified by the new Go test (clone step index precedes guardrail check index in the generated lock file).
✅ The opt-in GH_AW_ALLOW_INSECURE_REPO_MEMORY_AIC fallback is preserved for operators who need it, keeping the fail-closed default intact for untrusted paths.

@copilot please address the review comments above.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet50 · 86.6 AIC · ⌖ 13.6 AIC · ⊞ 10.1K
_{Comment /matt to run again}

github-actions · 2026-10-05T15:49:58Z

 	}
 	if data.MaxDailyAICBackend == maxDailyAICBackendRepoMemory {
-		steps = append(steps, "          GH_AW_ALLOW_INSECURE_REPO_MEMORY_AIC: ${{ vars.GH_AW_ALLOW_INSECURE_REPO_MEMORY_AIC || 'false' }}\n")
+		steps = append(steps, "          GH_AW_DAILY_AIC_REPO_MEMORY_TRUSTED: \"true\"\n          GH_AW_ALLOW_INSECURE_REPO_MEMORY_AIC: ${{ vars.GH_AW_ALLOW_INSECURE_REPO_MEMORY_AIC || 'false' }}\n")


[/diagnosing-bugs] Building on the existing review comment: the real root cause is that the clone step has no id: and no output distinguishing "real clone succeeded" from "clone failed, orphan created." Trust is set unconditionally here with no gate on the clone's result.

💡 Suggested fix

In clone_repo_memory_branch.sh, emit a step output (e.g. echo "cloned=true" >> "$GITHUB_OUTPUT" on the success branch, cloned=false otherwise), give the clone step an id: in buildDailyAICRepoMemoryCloneStep, and gate this line with if: steps.<clone-id>.outputs.cloned == 'true' (mirroring the steps.<id>.outcome == 'success' pattern already used in cache_memory.go:274). Also add a regression test asserting the guardrail stays untrusted/fails-closed when the clone step fails or falls back to orphan creation — today's new test only covers the already-trusted happy path.

@copilot please address this.

Implemented in f48f8b3: the clone step now has an ID and emits a cloned output, and guardrail trust is conditioned on that output. Regression tests cover verified missing branches, successful clones, clone failures, and remote verification failures.

done

gh-aw-bot · 2026-10-05T16:30:26Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.
Review (pkg/workflow/compiler_activation_daily_aic.go:144): This marks the ledger trusted even when no authenticated clone was obtained. clone_repo_memory_branch.sh converts every git clone failure—including token, network, or server failures—into an empty directory/orphan branch and exits successfully (lines 124–149), so the following guardrail now reads zero entries and permits the agent to run. Please derive this signal from a clone path that distinguishes a verified missing branch from transport/authentication errors, and fail closed for unclassified clone failures. - Trust repo-memory ledgers in the daily AIC guardrail #65879 (comment)
Review (pkg/workflow/compiler_activation_daily_aic.go:144): [/diagnosing-bugs] Building on the existing review comment: the real root cause is that the clone step has no id: and no output distinguishing "real clone succeeded" from "clone failed, orphan created." Trust is set unconditionally here with no gate on the clone's result. - Trust repo-memory ledgers in the daily AIC guardrail #65879 (comment)
Fix failing check agent (FAILURE): https://github.com/github/gh-aw/actions/runs/37332633997/job/111846694073.
Fix failing check conclusion (FAILURE): https://github.com/github/gh-aw/actions/runs/37332633997/job/111855005124.
Fix failing check conclusion (FAILURE): https://github.com/github/gh-aw/actions/runs/37332633936/job/111849464546.
Fix failing check impacted-go-tests (FAILURE): https://github.com/github/gh-aw/actions/runs/37332634327/job/111845847951.
Fix failing check impacted-go-tests (FAILURE): https://github.com/github/gh-aw/actions/runs/37330957941/job/111840277261.

Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI.

Sous-chef head: 261f0d1
Sous-chef work: 1234fa2c492e295ec4c48e6b5ab23b6398d4da1cf190fbb4b52a7302b402972f 34f38971738f6a752a646bd7797a6c8d47fb096e4eb6f91e946a91255433c8c4 42e5d572d9d75b7168fe7d0aeda0717cc07e65ed240f6d299e6fec661214f1ac 51e2287c3d1ee41b7e13769862add61dcd292a623cf943abc5968c984e246bcf d99bbf93feb6a5b8ddeeef577a59fd75356582a6cc93e99e9300569d26f35a76
Sous-chef state: 2b499ba3b899f6b857e0697bb8eae7a8703f0b5a8a485f0124b3360fd081ea59

Generated by 👨‍🍳 PR Sous Chef · pi · haiku45 · 3.79 AIC · ⌖ 6.87 AIC · ⊞ 1K · ◷
_{Comment /souschef to run again}

…olve-untrusted-aic-ledger Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

pelikhan · 2026-10-05T17:20:19Z

@copilot fix https://github.com/github/gh-aw/actions/runs/37344606213/job/111888804605?pr=65879

…olve-untrusted-aic-ledger Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-10-05T17:37:29Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes....

Merged the latest main with make merge-main and pushed 0e601b2. The clone step verifies the branch with authenticated git ls-remote, emits trust only after a successful clone, and fails closed on unclassified errors; clone regression coverage passes. I also fixed the impacted-Go test failure by narrowing its Node check to executable invocations. make lint and make agent-report-progress pass. The earlier agent-review failure was an agentic_engine_timeout, not locally reproducible; CI on this pushed head still needs a human-triggered rerun.

@copilot fix https://github.com/github/gh-aw/actions/runs/37344606213/job/111888804605?pr=65879

Fixed in 0e601b2: the failing Go assertion now distinguishes an actual Node executable invocation from the script's command -v node availability check. The targeted test and final impacted-test gate pass locally. CI on the pushed head is stale and needs a maintainer-triggered rerun.

pelikhan · 2026-10-05T18:00:03Z

@copilot fix https://github.com/github/gh-aw/actions/runs/37351678152/job/111903970402?pr=65879

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-10-05T18:17:31Z

@copilot fix https://github.com/github/gh-aw/actions/runs/37351678152/job/111903970402?pr=65879

Fixed in 533adf8: the failing test now correctly rejects a conditional expression for concurrency.queue, which only accepts single or max. make agent-report-progress passes locally.

pelikhan · 2026-10-05T18:25:30Z

@copilot resolve the merge conflicts in this pull request

pelikhan · 2026-10-05T18:31:48Z

@copilot resolve the merge conflicts in this pull request

pelikhan · 2026-10-05T18:35:34Z

@copilot resolve the merge conflicts in this pull request

…olve-untrusted-aic-ledger # Conflicts: # pkg/workflow/notify_comment_test.go Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-10-05T18:48:29Z

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflict with latest main and pushed merge commit e1d3cea.

github-actions · 2026-10-05T23:07:07Z

🎉 This pull request is included in a new release.

Release: v0.91.0

Initial plan

97c78ba

Copilot AI assigned Copilot and pelikhan Oct 5, 2026

Copilot started work on behalf of pelikhan October 5, 2026 14:52

View session

Copilot AI linked an issue Oct 5, 2026 that may be closed by this pull request

[AW Top 10] 10 Resolve untrusted AIC ledger blocking daily workflows #65775

Closed

2 tasks

Trust repo-memory AIC ledgers after verified clone

261f0d1

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix untrusted AIC ledger issue blocking daily workflows~~ Trust repo-memory ledgers in the daily AIC guardrail Oct 5, 2026

Copilot AI requested a review from pelikhan October 5, 2026 15:18

Copilot finished work on behalf of pelikhan October 5, 2026 15:18

pelikhan marked this pull request as ready for review October 5, 2026 15:24

Copilot AI balanced review requested due to automatic review settings October 5, 2026 15:24

Copilot started reviewing on behalf of pelikhan October 5, 2026 15:25

View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

github-actions Bot requested changes Oct 5, 2026

View reviewed changes

github-actions Bot previously requested changes Oct 5, 2026

View reviewed changes

github-actions Bot mentioned this pull request Oct 5, 2026

[pr-sous-chef] Sous Chef Report: 1 PR nudged #65759

Closed

Copilot started work on behalf of gh-aw-bot October 5, 2026 16:30

View session

Copilot AI and others added 2 commits October 5, 2026 16:37

Merge remote-tracking branch 'origin/main' into copilot/aw-top-10-res…

ca920bf

…olve-untrusted-aic-ledger Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Fail closed on repo-memory clone errors

f48f8b3

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI requested a review from gh-aw-bot October 5, 2026 17:00

Copilot finished work on behalf of gh-aw-bot October 5, 2026 17:00

Copilot started work on behalf of pelikhan October 5, 2026 17:20

View session

Copilot AI and others added 2 commits October 5, 2026 17:27

Merge remote-tracking branch 'origin/main' into copilot/aw-top-10-res…

442aef6

…olve-untrusted-aic-ledger Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Fix usage artifact test false positive

0e601b2

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan October 5, 2026 17:38

Merge branch 'main' into copilot/aw-top-10-resolve-untrusted-aic-ledger

d7dd4da

Copilot started work on behalf of pelikhan October 5, 2026 18:00

View session

Copilot started work to fix failing Actions workflow(s) on behalf of pelikhan October 5, 2026 18:04

View session

Copilot finished work on behalf of pelikhan October 5, 2026 18:11

Copilot started work to fix failing Actions workflow(s) on behalf of pelikhan October 5, 2026 18:14

View session

Correct concurrency queue schema test expectation

533adf8

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan October 5, 2026 18:19

Copilot finished work on behalf of pelikhan October 5, 2026 18:20

Copilot started work on behalf of pelikhan October 5, 2026 18:29

View session

Merge remote-tracking branch 'origin/main' into copilot/aw-top-10-res…

e1d3cea

…olve-untrusted-aic-ledger # Conflicts: # pkg/workflow/notify_comment_test.go Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan October 5, 2026 18:52

Merge branch 'main' into copilot/aw-top-10-resolve-untrusted-aic-ledger

f9fe00a

pelikhan merged commit 52ae271 into main Oct 5, 2026
43 checks passed

pelikhan deleted the copilot/aw-top-10-resolve-untrusted-aic-ledger branch October 5, 2026 19:04

Copilot stopped work on behalf of pelikhan due to an error October 5, 2026 19:04
Pull request is not open

Conversation

Copilot AI commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Copilot AI Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 5, 2026

Uh oh!

github-actions Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 5, 2026

Comment Memory

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Request changes

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Uh oh!

github-actions Bot Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

gh-aw-bot commented Oct 5, 2026

Uh oh!

pelikhan commented Oct 5, 2026

Uh oh!

Copilot AI commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelikhan commented Oct 5, 2026

Uh oh!

Copilot AI commented Oct 5, 2026

Uh oh!

pelikhan commented Oct 5, 2026

Uh oh!

pelikhan commented Oct 5, 2026

Uh oh!

pelikhan commented Oct 5, 2026

Uh oh!

Copilot AI commented Oct 5, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 5, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Oct 5, 2026 •

edited

Loading

github-actions Bot commented Oct 5, 2026 •

edited

Loading

github-actions Bot commented Oct 5, 2026 •

edited

Loading

github-actions Bot commented Oct 5, 2026 •

edited

Loading

github-actions Bot commented Oct 5, 2026 •

edited

Loading

Copilot AI commented Oct 5, 2026 •

edited

Loading