Skip to content

Update Kiro CLI to 2.27.1 and fix smoke coverage and diagnostics - #65900

Merged
pelikhan merged 3 commits into
mainfrom
pelikhan-kiro-integration-review
Oct 5, 2026
Merged

pelikhan merged 3 commits into
mainfrom
pelikhan-kiro-integration-review

Conversation

@pelikhan

@pelikhan pelikhan commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

The experimental Kiro integration still pinned CLI 2.16.1. The latest smoke run completed successfully in Actions but reported a failed build because Go downloads were blocked; its GitHub MCP check also used gh-proxy rather than native MCP. This updates the integration to the published stable release and makes the smoke checks exercise the intended runtime.

  • Pin Kiro CLI 2.27.1 with independently verified SHA-256 checksums for both x86_64 and aarch64 Linux archives. Retain the existing API-key authentication, headless flags, model mapping, and native MCP configuration contract.
  • Add secret-safe MCP adapter and harness diagnostics for server counts, authentication presence, prompt size, installation timings, checksum verification, process failures, and cleanup. Preserve nonzero CLI exit codes, including MCP startup exit code 3, and reject malformed configuration explicitly.
  • Remove the smoke workflow's gh-proxy import, enable the Go runtime and Go network access, require native GitHub MCP without CLI fallbacks, and check the installed CLI version and MCP runtime configuration.
  • Add adapter and harness regression coverage, update the shared sample documentation and changeset, and regenerate the affected smoke and conformance lock files.

Validation

  • Downloaded both Linux 2.27.1 archives and matched their checksums against the official stable manifest; confirmed archive layout and build metadata.
  • make fmt
  • make recompile
  • go test ./pkg/workflow -run 'TestKiro' -count=1
  • gh aw compile smoke-kiro --strict --no-emit --no-check-update --schedule-seed github/gh-aw
  • ./gh-aw compile smoke-kiro engine-conformance-kiro --strict --no-emit --no-check-update --schedule-seed github/gh-aw
  • make agent-report-progress with modern Bash: Go lint, custom linters, impacted tests, schema freshness, and workflow drift checks passed.

Review notes

Kiro remains an unsupported experimental sample. The harness now rejects engine.version overrides that differ from its checksum-pinned release; update the definition version, harness version, and both checksums together.

Harness subprocess tests use a mocked CLI, while adapter tests execute the actual JavaScript. A fresh live smoke run was not triggered. Historical failure evidence: #65692.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review October 5, 2026 16:08
Copilot AI balanced review requested due to automatic review settings October 5, 2026 16:09
@pelikhan

pelikhan commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The smoke workflow incorrectly attempts to install nonexistent GitHub Copilot CLI version 2.27.1 for threat detection.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Updates the experimental Kiro integration to CLI 2.27.1 and improves native MCP, diagnostics, and smoke coverage.

Changes:

  • Pins verified Kiro binaries and adds safer runtime diagnostics.
  • Enables native GitHub MCP and Go build networking.
  • Adds regression tests and regenerates workflows.
File Description
.github/​workflows/​shared/​kiro.md Updates Kiro and runtime behavior.
.github/​workflows/​smoke-kiro.md Strengthens smoke requirements.
.github/​workflows/​smoke-kiro.lock.yml Regenerates the smoke workflow.
.github/​workflows/​engine-conformance-kiro.lock.yml Regenerates conformance output.
pkg/​workflow/​kiro_workflow_test.go Adds adapter and harness tests.
.changeset/​patch-kiro-release-smoke-diagnostics.md Records the release change.

Comment thread .github/workflows/smoke-kiro.lock.yml Outdated
package-manager-cache: false
- name: Install GitHub Copilot CLI
run: bash "${RUNNER_TEMP}/gh-aw/actions/install_copilot_cli.sh"
run: bash "${RUNNER_TEMP}/gh-aw/actions/install_copilot_cli.sh" 2.27.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated smoke lock no longer passes Kiro’s version to the Copilot installer; it invokes the installer without a version argument. This was regenerated in merge commit 438cc43.

@pelikhan

pelikhan commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflict by merging current main and regenerating the Kiro smoke lock. The merge resolution is in 438cc43.

Copilot AI commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

The PR branch already contains current main as parent 2 of merge commit 438cc43, and a fresh merge-tree check against origin/main reports no conflicts. GitHub currently reports the PR as blocked rather than conflicted, so there is no new merge conflict to resolve.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot address the following outstanding work in one pass:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.
  2. Review (.github/workflows/smoke-kiro.lock.yml:1947): This passes the Kiro version to the threat-detection job's GitHub Copilot CLI installer. github/copilot-cli has no 2.27.1 release (the current release is v1.0.91), so this unconditional install step will fail before threat detection runs. Prevent the Copilot detection config from inheriting the main Kiro engine's version, then regenerate this lock file. - Update Kiro CLI to 2.27.1 and fix smoke coverage and diagnostics #65900 (comment)

Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI.

Sous-chef head: d2f8d4f
Sous-chef work: 7061924ad18f605b9e189d44db1d53d80fc68d6efc33c2f0ad1219a5ae2f0b5e
Sous-chef state: ac773f81a8865a75f8f0db34719214aa05c6adeedf109ec24ff6c5fbdbe12564

Generated by 👨‍🍳 PR Sous Chef · pi · haiku45 · 3.21 AIC · ⌖ 6.71 AIC · ⊞ 1K · ◷
Comment /souschef to run again

Copilot AI commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

@copilot address the following outstanding work in one pass:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes....

make merge-main completed successfully; the branch already contained current main, so no new merge or code commit was needed. The smoke lock invokes the Copilot installer without Kiro’s version (fixed in 438cc43). make lint and make agent-report-progress passed, including impacted tests. I replied to the review thread, but this environment has no GitHub API token or thread-resolution tool, so it remains open for a human to resolve. Existing CI is action-required; I did not trigger it.

Copilot AI requested a review from gh-aw-bot October 5, 2026 17:18
@pelikhan
pelikhan merged commit bcb482d into main Oct 5, 2026
2 checks passed
@pelikhan
pelikhan deleted the pelikhan-kiro-integration-review branch October 5, 2026 17:21
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.91.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants