Repository navigation
[spec-enforcer] Enforce specifications for timeutil, tty, types - #68673
Merged
Merged
Conversation
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification Test Enforcement
This PR updates specification-driven tests for the round-robin package set. The
ttysuite now checks each documented standard stream using a deterministic pipe and all specification tests use the requiredTestSpec_prefix. The existingtimeutilandtypessuites remain aligned with their READMEs.timeutilttytypesTest Derivation
All tests are derived from README.md specifications, not from implementation source code.
Spec-Implementation Mismatches
None found.
Validation
go build ./pkg/timeutil/... ./pkg/tty/... ./pkg/types/...go test -v -run "TestSpec" ./pkg/timeutil/ ./pkg/tty/ ./pkg/types/spec-enforcer/generated-testsmake agent-report-progresspassed formatting, build, schema, custom-linter, and impacted-test stages, but could not complete becausegolangci-lintis unavailable in the runnerRound-Robin State
timeutil,tty,typestypeutil,validationerror,workflowReferences: