Repository navigation
Conversation
Use direct inline JSON for CLI calls, preserve native transport boundaries, and report blocked submissions without unapproved shell workarounds. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
Great work aligning safe-output guidance with actual permissions! This focused PR with clear validation looks ready for review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI-proxy automatically permits the
safeoutputsexecutable, but it does not grant auxiliary commands such asjqor shell file-staging operations. Runtime guidance nevertheless recommended heredoc staging andjqpipelines, leading agents into permission denials, including Daily SPDD Spec Planner run 38593520635.Replace those recommendations in the CLI-proxy, base safe-output, and shell-expansion-guard prompts with direct, shell-quoted inline JSON and escaped newlines. Preserve native tool usage only when explicitly exposed, and direct blocked submissions to
report_incompletewithout unapproved shell workarounds. No workflow permissions, safe-output budgets, denial limits, or transport configuration are broadened.Regression coverage checks that the prompts no longer recommend helper serialization, parses the documented JSON example, and verifies that the actual SDK permission handler accepts it with only
shell(safeoutputs:*)while rejecting an unauthorizedjqpipeline.Validation:
make fmt-cjs,make lint-cjs, focused composed-prompt Go tests, all 11 workflow tool-policy alignment tests, andmake agent-report-progresspassed. No workflow was dispatched.Coordination: the helper-based guidance in the separate, unmerged #68716 needs reconciliation with this user-directed approach.