Skip to content
This repository was archived by the owner on Apr 15, 2025. It is now read-only.

Update go version in mod and workflows - #109

Merged
hoenn merged 1 commit into
mainfrom
hoenn/upgrade-go-versions
Feb 12, 2024
Merged

Update go version in mod and workflows#109
hoenn merged 1 commit into
mainfrom
hoenn/upgrade-go-versions

Conversation

@hoenn

@hoenn hoenn commented Feb 8, 2024

Copy link
Copy Markdown
Contributor

Upgrades the go version we build and test with from 1.15 -> 1.22 to be able to upgrade passed stdlib vulnerabilities. Also simplifies CI by: not running lint in every test workflow, removes multiple go version testing.

@hoenn
hoenn force-pushed the hoenn/upgrade-go-versions branch from fa7109d to d8a39f4 Compare February 12, 2024 14:48
@hoenn
hoenn marked this pull request as ready for review February 12, 2024 14:51
@hoenn
hoenn requested a review from a team February 12, 2024 14:51

@tomthorogood tomthorogood left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@ndonewar

Copy link
Copy Markdown

Since we're doing upgrade work, should we upgrade to Go 1.22 now that it is released? The Go release policy states that versions are only supported "until there are two newer major releases" (e.g, 1.21 and 1.22). Also, it looks like 1.21.* included some security fixes.

@hoenn
hoenn force-pushed the hoenn/upgrade-go-versions branch from 4dda2c9 to 5aa4c1f Compare February 12, 2024 16:24
@hoenn
hoenn merged commit 3a9d57f into main Feb 12, 2024
@hoenn
hoenn deleted the hoenn/upgrade-go-versions branch February 12, 2024 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants