Avoid undefined array key warnings when parsing HPP responses without uppercase keys#142
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
… uppercase keys Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #139.
HostedService::parseResponse()readsTIMESTAMP,MERCHANT_ID,ORDER_ID,RESULT,MESSAGEandPASREFwith bare array access, so on PHP 8+ a response that does not contain those uppercase keys (for example a lightbox HPP response that only goes through the non-fundsstatusbranch) emits one "Undefined array key" warning per field before the hash is even checked. This guards those reads with?? "", matching theAUTHCODE/PAYMENTMETHODlines just below them, and adds a parseResponse test that fails with the old code and passes with the guard.