Skip to content

Remove Geometries and move these attributes onto the element #37

Closed

Description

@fwkoch

Every time you create an Element you must also create a Geometry. These geometries do not have meaning without the information from the element. It would reduce complexity in the data format if geometric info (vertices, segments, etc) was an attribute on each Elements.

Current implementation (and associated serialization):

pts = omf.PointSetElement(
    name='Random Points',
    description='Just random points',
    geometry=omf.PointSetGeometry(
        vertices=np.random.rand(100, 3)
    )
    color='green'
)

Proposed implementation (and associated serialization):

pts = omf.PointSetElement(
    name='Random Points',
    description='Just random points',
    vertices=np.random.rand(100, 3),
    color='green'
)

This would remove the PointSetGeometry structure from the file format. See documentation here:
https://omf.readthedocs.io/en/latest/content/pointset.html#omf.pointset.PointSetGeometry

The proposed attributes on each element would be proposed to have the same naming as the current names on each geometry.

Activity

  1. added
    ⬇️ 🍏Low hanging fruit, easy improvements to OMF format.
    on Jan 24, 2019
  2. self-assigned this
    on Mar 29, 2019
  3. added a commit that references this issue on Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

⬇️ 🍏Low hanging fruit, easy improvements to OMF format.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions