Activate release during application deploy#77
Open
dsingh5-godaddy wants to merge 1 commit into
Open
Conversation
Call activateRelease before setting application status to ACTIVE in godaddy application deploy. Add GraphQL mutation wrapper, MSW handler, and deploy tests asserting activation order. Co-authored-by: Cursor <cursoragent@cursor.com>
wcole1-godaddy
approved these changes
Jul 2, 2026
wcole1-godaddy
left a comment
wcole1-godaddy
left a comment
Contributor
There was a problem hiding this comment.
Approved. I reviewed the activation sequencing and ran validation in a clean detached worktree: typecheck, build, targeted deploy/CLI tests, application service integration test, diff check, and the Effect migration grep checks were clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call activateRelease before setting application status to ACTIVE in godaddy application deploy. Add GraphQL mutation wrapper, MSW handler, and deploy tests asserting activation order.
Since we merged DEVX-363: Use latest ACTIVE release by activatedAt for app enablement, releases created via the CLI can no longer be enabled because the CLI doesn't activate releases yet.
I've raised a follow-up PR to: