Repository navigation
Fix tuple reconstruction of non-mappable dataclasses - #469
Open
Linxiushen wants to merge 2 commits into
Open
Linxiushen wants to merge 2 commits into
Linxiushen wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Linxiushen
force-pushed
the
fix/non-mappable-tuple-conversion
branch
from
September 28, 2026 03:54
ef1ec96 to
63bfddb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_tuple()passes azipobject as the sole positional constructor argument. This works for mapping dataclasses, but withmappable_dataclass=Falsea multi-field dataclass raisesTypeError, and a one-field dataclass silently stores thezipobject instead of its value.Construct from field-name keyword arguments so both supported dataclass modes receive the original values. Extend the tuple round-trip test across mapping/non-mapping, mutable/frozen and keyword-only constructors, and check that a restored single JAX-array field still works in a jitted function.
Validation on Python 3.12 / JAX 0.11.2 CPU:
python -m pytest chex/_src/dataclass_test.py -q --tb=short: 69 passed.test.shFlake8 selection and Google-configured Pylint on both changed files pass. Ruff reports the same two existing source diagnostics as the baseline, neither in changed code.The full repository, docs, other Python versions and GPU tests were not run. This does not change pseudo-field or non-mapping
init=Falsefield behavior.