Repository navigation
overlay: check the file cache mutex - #16968
Merged
Merged
Conversation
Copy-up replaces the cached file and its status flags under the overlay file mutex. Mark all three cache fields so checklocks can verify that readers and writers hold the same lock. The last reference to the overlay file has already been dropped when VFS calls Release, so teardown can drop the cached file without locking.
copybara-service
Bot
force-pushed
the
test/cl1013860148
branch
3 times, most recently
from
November 4, 2026 21:17
38d54c6 to
22ebd4d
Compare
PiperOrigin-RevId: 1014160811
copybara-service
Bot
force-pushed
the
test/cl1013860148
branch
from
November 4, 2026 23:08
22ebd4d to
a11d178
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overlay: check the file cache mutex
Copy-up replaces the cached file and its status flags under the overlay
file mutex. Mark all three cache fields so checklocks can verify that
readers and writers hold the same lock.
The last reference to the overlay file has already been dropped when
VFS calls Release, so teardown can drop the cached file without locking.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#16682 from tamird:review/overlay-file-cache-guards 05eca6e