Repository navigation
cmdline: reject inconsistent cgroup memory limits - #318
Open
samuelgirmametaferia wants to merge 1 commit into
Open
samuelgirmametaferia wants to merge 1 commit into
samuelgirmametaferia wants to merge 1 commit into
Conversation
Contributor
Author
|
Hey could you please review this! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject configurations where
cgroup_mem_memsw_maxis smaller thancgroup_mem_max.cgroup_mem_memsw_maxrepresents a combined memory+swap limit. On cgroup v2 nsjail derivesmemory.swap.maxby subtractingcgroup_mem_maxfrom that value. When the combined limit is smaller than the memory limit, that unsigned subtraction underflows before being stored in the signed swap-limit variable. The resulting negative value can cause thememory.swap.maxwrite to be skipped, silently weakening the requested resource boundary.Reject the inconsistent relationship during argument/config validation instead of allowing the cgroup setup path to interpret the underflowed value.
Validation
make -j2 nsjail: PASSmake test-cmdline: PASS, including the new inconsistent-limit regressiongit diff --check: PASSmake test: command-line tests and all nstun unit tests pass; the suite then stops at the existing host restriction that denies writing/proc/<pid>/setgroupsGit history and upstream PR/issue searches found no equivalent validation change. Historical PRs #184 and #186 added the memsw controls, and #278 adjusted swap-only cleanup, but none reject this invalid limit relationship.