Repository navigation
tests: build and run path_containment_test - #322
Open
andreeapid wants to merge 1 commit into
Open
andreeapid wants to merge 1 commit into
andreeapid wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
tests/path_containment_test.cc is not listed in TEST_BINS, so "make test" never
builds or runs it. It also does not compile with the project's own flags: the
two system("rm -rf ...") cleanup calls trip -Werror=unused-result.
Add it to TEST_BINS and to the test target, and give it a private temporary
directory created with mkdtemp instead of the fixed /tmp paths it cleaned up
with system().
Contributor
Author
|
Rebased on master after #316 added nstun_udp_peer_test to the Makefile. No other change. |
andreeapid
force-pushed
the
run-path-containment-test
branch
from
October 9, 2026 05:35
1c2a7c2 to
676aea1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/path_containment_test.ccis not listed inTEST_BINS, somake testnever builds or runs it. It also does not compile with the project's own flags:
the two
system("rm -rf ...")cleanup calls trip-Werror=unused-result.Add it to
TEST_BINSand to the test target, and give it a private temporarydirectory from
mkdtempinstead of the fixed/tmp/nsj_path_testand/tmp/nsj_sym_stagepaths, so the test cannot be influenced by whatever isalready at those names.
Tested on Ubuntu 26.04, kernel 7.0.0-15-generic, gcc 15.2.0: builds and passes.