Skip to content

logs: refuse symlink log targets - #336

Closed
ManyGlue0 wants to merge 1 commit into
google:masterfrom
ManyGlue0:codex/fix-refuse-symlink-logs
Closed

ManyGlue0 wants to merge 1 commit into
google:masterfrom
ManyGlue0:codex/fix-refuse-symlink-logs

Conversation

@ManyGlue0

Copy link
Copy Markdown

Add O_NOFOLLOW to the log-file open flags.

This prevents a configured log path from following a symlink when nsjail creates or appends the log file, avoiding an attacker-selected target while preserving the existing error handling.

Fixes #323

@google-cla

google-cla Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@robertswiecki

Copy link
Copy Markdown
Collaborator

Thank you, merged in #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants