Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request moves the retry classes (RetryRunner, ExponentialRetry) and ChecksumValidationException from google_cloud_storage to google_cloud_rpc while maintaining backwards compatibility through re-exports. It also adds corresponding unit tests and updates the librarian configuration. Regarding the feedback, using const constructors in the equality and hash code tests for ExponentialRetry can result in false positives due to Dart's canonicalization of constants; it is recommended to use final (non-const) instances instead to properly verify the equality implementation.
|
Filed #359 as a follow-up to wire |
…ud_storage TAG=agy CONV=4ecd3490-bbbe-499e-90e5-07ea5e14a460
… to ExponentialRetry TAG=agy CONV=4ecd3490-bbbe-499e-90e5-07ea5e14a460
2 participants
Extracts
RetryRunner,ExponentialRetry(adding optionaljitter),delaySequence(computingnoRetriesAftereagerly whendelaySequence()is called),defaultRetry,NoDelayRetry, andChecksumValidationExceptionfrompackage:google_cloud_storageintopackage:google_cloud_rpc/retry.dart.package:google_cloud_storagere-exportspackage:google_cloud_rpc/retry.dartfor backwards compatibility.pkgs/google_cloud_storage/test/retry_test.darttogenerated/google_cloud_rpc/test/retry_test.dart.Split out from #292 (1/4).
Closes #346