Skip to content

Introduce doc generation tools - #18

Merged
dwsupplee merged 4 commits into
googleapis:masterfrom
dwsupplee:docs
Mar 1, 2016
Merged

Introduce doc generation tools#18
dwsupplee merged 4 commits into
googleapis:masterfrom
dwsupplee:docs

Conversation

@dwsupplee

@dwsupplee dwsupplee commented Feb 19, 2016

Copy link
Copy Markdown
Contributor

@dwsupplee dwsupplee added documentation do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 19, 2016
@callmehiphop

callmehiphop commented Feb 19, 2016

Copy link
Copy Markdown
Contributor

👍 is there a demo?

@dwsupplee

dwsupplee commented Feb 19, 2016

Copy link
Copy Markdown
Contributor Author

Working on getting a pretty rough demo of the gh-pages up right now

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2016
tmatsuo
tmatsuo reviewed Feb 19, 2016
View reviewed changes
Comment thread scripts/DocGenerator.php
@@ -0,0 +1,233 @@
<?php

This comment was marked as spam.

Sign in to view

@dwsupplee

dwsupplee commented Feb 22, 2016

Copy link
Copy Markdown
Contributor Author

WIP version of the docs site for anyone interested :)

http://dwsupplee.github.io/gcloud-php/#/

@JustinBeckwith

JustinBeckwith commented Feb 22, 2016

Copy link
Copy Markdown
Contributor

looking good!

@dwsupplee dwsupplee removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. in progress labels Feb 26, 2016
bshaffer
bshaffer reviewed Feb 26, 2016
View reviewed changes
Comment thread composer.json Outdated
"autoload": {
"psr-4": {
"Google\\Cloud\\": "src"
"Gcloud\\": "src"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dwsupplee added a commit that referenced this pull request Mar 1, 2016
@dwsupplee
Merge pull request #18 from dwsupplee/docs
7d2fd94 
Introduce doc generation tools
@dwsupplee
dwsupplee merged commit 7d2fd94 into googleapis:master Mar 1, 2016
@tmatsuo

tmatsuo commented Mar 1, 2016

Copy link
Copy Markdown
Contributor

Nice work! Just a small nit, the demo still says composer install google/cloud, but now it should be google/gcloud? I understand that it is just a demo, but I'm wondering where it comes from.

@dwsupplee

dwsupplee commented Mar 1, 2016

Copy link
Copy Markdown
Contributor Author

Thanks @tmatsuo!

Good eye. You're correct it should be google/gcloud, I'll make sure it gets corrected.

@cedricziel

cedricziel commented Mar 1, 2016

Copy link
Copy Markdown
Contributor

The example on the frontpage has an issue with escaping

@dwsupplee

dwsupplee commented Mar 1, 2016

Copy link
Copy Markdown
Contributor Author

Thanks @cedricziel. It appears there may be a configuration issue with hljs (the syntax highlighting library our docs site uses). Working on it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dwsupplee @callmehiphop @JustinBeckwith @tmatsuo @cedricziel @bshaffer @googlebot