Batch branch update - #551
Merged
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
FYI, I observed acceptable performance with my PHP App Engine Flex app with the Error Reporting enabled with this code (still little bit slow though). |
dwsupplee
reviewed
Jun 30, 2017
| { | ||
| $client = array_key_exists('clientConfig', $options) | ||
| ? new self($options['clientConfig']) | ||
| : new self(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@dwsupplee Yeah now it should set |
dwsupplee
approved these changes
Jun 30, 2017
dwsupplee
pushed a commit
to dwsupplee/gcloud-php
that referenced
this pull request
Jun 30, 2017
* Documentation update * Use GCLOUD_PROJECT envvar for project id detection. * Added a static factory method for creating batch enabled PsrLogger * Force enabling the batch mode
dwsupplee
pushed a commit
to dwsupplee/gcloud-php
that referenced
this pull request
Jun 30, 2017
* Documentation update * Use GCLOUD_PROJECT envvar for project id detection. * Added a static factory method for creating batch enabled PsrLogger * Force enabling the batch mode
Contributor
Author
|
The guide is now updated to reflect this change, thanks! |
dwsupplee
pushed a commit
to dwsupplee/gcloud-php
that referenced
this pull request
Jun 30, 2017
* Documentation update * Use GCLOUD_PROJECT envvar for project id detection. * Added a static factory method for creating batch enabled PsrLogger * Force enabling the batch mode
jdpedrie
pushed a commit
that referenced
this pull request
Jun 30, 2017
* Adding Batch package and PsrBatchLogger. * Added appengine.googleapis.com/trace_id for log request correlation. * Evaluate the $_SERVER for each request for creating labels for log request correlation. * Correctly add the labels * Added a test around the TraceId * Fixed wrong tests * Evaluate $server in the constructor. * Added metadataProvider to PsrLogger * Fix the document generation error (#469) * Dynamically change the number of children (#489) * Dynamically change the number of children * Add AsyncReporter for trace which relies on the batch runner (#548) * Introduce batch publisher (#534) * introduce batch publisher * Add copyright * batch updates * fix bootstrap * add coverage for batchPublisher * remove unused imports * fix @see link * Batch branch update (#551) * Documentation update * Use GCLOUD_PROJECT envvar for project id detection. * Added a static factory method for creating batch enabled PsrLogger * Force enabling the batch mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.