feat(adk): pass telemetry attributes through toolbox-adk - #720
Merged
anubhav756 merged 3 commits intoJul 28, 2026
Merged
Conversation
Contributor
|
/gcbrun |
anubhav756
marked this pull request as ready for review
July 21, 2026 06:30
anubhav756
force-pushed
the
feat/adk-telemetry-attributes-integration
branch
from
July 21, 2026 06:30
41cada5 to
ced41bb
Compare
Contributor
|
/gcbrun |
AjmeraParth132
force-pushed
the
feat/adk-telemetry-attributes-integration
branch
2 times, most recently
from
July 21, 2026 06:44
2baed48 to
c69e841
Compare
Contributor
|
/gcbrun |
anubhav756
approved these changes
Jul 21, 2026
anubhav756
left a comment
anubhav756
left a comment
Contributor
There was a problem hiding this comment.
As discussed let's add documentation to the docsite repo following this. I'm also thinking if we can optionally add some integration tests as well?
anubhav756
approved these changes
Jul 21, 2026
anubhav756
approved these changes
Jul 21, 2026
Contributor
|
/gcbrun |
anubhav756
force-pushed
the
feat/adk-telemetry-attributes-integration
branch
from
July 22, 2026 11:46
84265e7 to
fecb875
Compare
Contributor
|
/gcbrun |
anubhav756
force-pushed
the
feat/adk-telemetry-attributes-integration
branch
from
July 23, 2026 08:24
fecb875 to
611a197
Compare
twishabansal
approved these changes
Jul 23, 2026
twishabansal
left a comment
twishabansal
left a comment
Contributor
There was a problem hiding this comment.
Approving to unblock multi approvers CI check
Contributor
|
/gcbrun |
Contributor
Author
|
also, @anubhav756 can you ptal at the failing checks, looks like an issue with integration tests' google cloud set up!
|
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
toolbox-corenow supportsTelemetryAttributesand sends them through MCP_metafor extended telemetry / SQLCommenter (#632, #634).toolbox-adkdid not expose that flow, so ADK users could not attach model, user ID, or agent ID metadata when invoking Toolbox tools throughToolboxToolset.This PR adds ADK pass-through support for telemetry attributes.
Changes
telemetry_attributestoToolboxToolset.telemetry_attributesinto each wrappedToolboxTool.telemetry_attributessupport toToolboxTool.TelemetryAttributesand sync/async callbacks.ToolContext, matching the existing auth token getterpattern from feat(adk): Support
ToolContextforauth_token_gettersintoolbox-adk#579.add_telemetry_attributes(...).leak between invocations.
bind_params(...)returns a new ADK wrapper.Related
ToolContextcallback pattern from feat(adk): SupportToolContextforauth_token_gettersintoolbox-adk#579.