Skip to content
This repository was archived by the owner on Feb 15, 2026. It is now read-only.

chore: migrate to owlbot - #62

Merged
bcoe merged 8 commits into
mainfrom
migrateToOwlBot
Mar 30, 2021
Merged

chore: migrate to owlbot#62
bcoe merged 8 commits into
mainfrom
migrateToOwlBot

Conversation

@sofisl

@sofisl sofisl commented Mar 29, 2021

Copy link
Copy Markdown
Contributor

Fixes #61

@sofisl
sofisl requested review from a team, SurferJeffAtGoogle and bcoe March 29, 2021 17:07
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 29, 2021
@codecov

codecov Bot commented Mar 29, 2021

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@bcb0d23). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage        ?   84.61%           
=======================================
  Files           ?        3           
  Lines           ?      156           
  Branches        ?       19           
=======================================
  Hits            ?      132           
  Misses          ?       24           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb0d23...fa1c35f. Read the comment docs.

@SurferJeffAtGoogle SurferJeffAtGoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have you tried running the the nodejs post processor with these changes? Not sure how it will behave with an empty version list.

@bcoe bcoe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple notes about the migration progress, post process ran and this is looking good though.

Comment thread .github/workflows/ci.yaml
on:
push:
branches:
- $default-branch

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sofisl after we merge this, we can update the templates in synthtool to use $default-branch.

Comment thread README.md
## Samples

Samples are in the [`samples/`](https://github.com/googleapis/nodejs-local-auth/tree/main/samples) directory. Each sample's `README.md` has instructions for running its sample.
Samples are in the [`samples/`](https://github.com/googleapis/nodejs-local-auth/tree/master/samples) directory. Each sample's `README.md` has instructions for running its sample.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is slightly more of a pain in the neck, and will need to be fixed when we move everything over.

@bcoe
bcoe merged commit 570b70f into main Mar 30, 2021
@bcoe
bcoe deleted the migrateToOwlBot branch March 30, 2021 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Synthesis failed for nodejs-local-auth

3 participants