feat(editor): chord grips may use open voicings — flagged for individual review

[ChrisBeWithYou]

What

Follow-up to #245, implementing the agreed "use opens, flag for review" policy from the review discussion:

1. _resolveChordGripPure no longer bails on a cluster note playable both open and fretted — it may voice the note open (opens are how real chord shapes use the neck, and the span metric naturally prefers them), tagging the pick ambiguousOpen whenever a fretted alternative was eligible.
2. _resolveWindowPure propagates the tag onto its moves and returns an ambiguousOpen index list — including identity picks (a note already sitting on the chosen open string writes no move but still needs the review gate).
3. The sweep's Accept all excludes flagged refs through the exact same pure gate refused notes already use (_acceptAllRefsPure with a unioned review-only set) — the charter confirms each machine-chosen open individually, in view. The status line counts them ("… · 2 open voicings to review").

Deliberately unchanged: the singleton resolver (_suggestPositionPure) still refuses open-vs-fretted — outside a chord shape there is nothing to justify the machine deciding. A new scope-guard test pins that.

Tests

• tests/chord_grip.test.mjs: the three ambiguity cases flip from refuse→grip+flag (min-span grip with the open tagged; D+G dyad collapses to two opens, both tagged; the _resolveWindowPure integration case asserts flag propagation).
• New tests/open_voicings.test.mjs (5): unambiguous open never flagged; fretted pick never flagged even with an open alternative; identity pick still listed for review; singleton scope guard; Accept-all exclusion. The behavioral cases fail on main (grip returns null there).
• Full suite 147/147 green, lint 0 errors (3 pre-existing ratchet warnings), routes.py untouched.

Notes

• CHANGELOG: rewrote the tail of the feat(editor): resolve chords as one coherent grip, not a greedy spread #245 entry (its "still refused, never quietly voiced open" sentence is what this PR changes) and added the new entry; also removed two stray duplicated fragments in [Unreleased] left by earlier merges (the Map Health and onset-detection entries each had a repeated tail line).

🤖 Generated with Claude Code

https://claude.ai/code/session_01EBQCHCNA81E9tHmSDHSe2Q

Summary by CodeRabbit

• New Features
  • Chord resolution can now select open strings when they create the tightest playable shape.
  • Potentially ambiguous open-string choices are flagged for individual review.
  • Accept all confirms eligible suggestions while leaving flagged open-string choices for review.
• Bug Fixes
  • Improved handling and status reporting for chord-position resolution.
  • Preserved refusal behavior for ambiguous standalone notes outside chord shapes.
• Documentation
  • Clarified tempo/grid resolution and open-voicing review behavior in the changelog.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b7692d6f-761e-4561-bfc1-8178194fc8cc

📥 Commits

Reviewing files that changed from the base of the PR and between 5b73cad and d8383a6.

📒 Files selected for processing (5)

• CHANGELOG.md
• src/anchor-resolve.js
• src/position.js
• tests/chord_grip.test.mjs
• tests/open_voicings.test.mjs

---

📝 Walkthrough

Walkthrough

Chord-grip resolution now permits ambiguous open-string placements, marks them for review, propagates those markers through window resolution, and excludes them from bulk confirmation. Tests cover grip selection, propagation, singleton refusal, and Accept all behavior. Changelog wording was updated.

Changes

Open voicing resolution

Layer / File(s)	Summary
Chord-grip ambiguity tracking src/position.js, tests/chord_grip.test.mjs, tests/open_voicings.test.mjs	Chord grips retain eligible open-string placements, record fretted alternatives, and mark ambiguous open assignments with ambiguousOpen.
Window propagation and sweep review src/anchor-resolve.js, tests/chord_grip.test.mjs, tests/open_voicings.test.mjs, CHANGELOG.md	Window resolution propagates ambiguous-open indices and move flags; confirmation sweeps exclude refused and ambiguous-open notes from Accept all, with updated status text and changelog descriptions.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• got-feedBack/feedBack-plugin-editor#143: Both changes address open-versus-fretted ambiguity in string and fret placement resolution.
• got-feedBack/feedBack-plugin-editor#201: This change extends the existing confirmation-sweep filtering to ambiguous-open placements.
• got-feedBack/feedBack-plugin-editor#245: Both changes modify chord-grip and anchor-window resolution behavior for open-versus-fretted cases.

Sequence Diagram(s)

sequenceDiagram
  participant Editor
  participant _resolveWindowPure
  participant _resolveChordGripPure
  participant ConfirmationSweep
  Editor->>_resolveWindowPure: resolve anchor window
  _resolveWindowPure->>_resolveChordGripPure: resolve chord grip
  _resolveChordGripPure-->>_resolveWindowPure: assignments with ambiguousOpen
  _resolveWindowPure-->>Editor: moves and review indices
  Editor->>ConfirmationSweep: accept all with reviewOnly refs
  ConfirmationSweep-->>Editor: confirm only non-review refs

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: chord grips can use open voicings, and ambiguous ones are flagged for review.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/editor-open-voicings

---

_{Comment @coderabbitai help to get the list of available commands.}