fix(editor): suggest march backfills bridged-bar confidence once the far side confirms (c5 follow-up) - #272
Merged
Merged
Conversation
The #231 scope-note follow-up: misses bridged BETWEEN two corroborated hits are retroactively lifted to 75% of the weaker flank's INTRINSIC strength (comb x consistency — the closing hit's published conf is already continuity-penalized for the very gap being backfilled, so using it would double-count). Trailing misses keep the floor and still drop; locked pins corroborate at full trust; backfilled bars never outrank a real hit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EBQCHCNA81E9tHmSDHSe2Q
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAssisted tempo suggestion now backfills confidence for missed bars when later corroboration or a locked bar confirms the march. New tests cover successful backfill, unreconfirmed misses, and full-trust locked-bar behavior. ChangesAssisted tempo backfill
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EBQCHCNA81E9tHmSDHSe2Q
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The explicitly-noted #231 scope gap ("c5's retroactive confidence backfill is a noted follow-up"): when the assisted fit marches across a sustained bar on bare prediction, it assigns the floor confidence — and left it there even after the next bar snapped cleanly, proving the marched path correct. The ghost over a held chord read as "guessing" when the evidence said "probably right".
_suggestFitPure's signature and public proposal shape are unchanged.Tests
tests/suggest_backfill.test.mjs(3, fail on main — mid-run misses keepconf === missConfthere): the bridged-bar lift with the never-outranks bound, the trailing-drop unchanged, and the locked-pin corroboration. Existingtempo_suggestpins all green unchanged. Full suite 147 green, lint 0 errors,routes.pyuntouched.Notes
Purely a confidence-metadata change — proposal times, stops, and accept behaviour are untouched; the visible effect is honest ghost-alpha over bridged bars (and better zone-refine confidence readings downstream).
🤖 Generated with Claude Code
https://claude.ai/code/session_01EBQCHCNA81E9tHmSDHSe2Q
Summary by CodeRabbit
Improvements
Tests