feat(editor): Tracks-view regions become glass banners with the notes tucked below the title - #349
Conversation
|
Warning Review limit reached
Next review available in: 8 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… tucked below the title A region block now reads as a titled object: a translucent kind-colour title band over a top-lit glass fill that fades to almost nothing, with a rounded border that accents + glows on selection. The note silhouette / waveform is inset below the band so notes never cross the header line, and the region name is vertically centred in the band so descenders stay inside it. Short lanes (< ~23px) degrade to a bare colour spine so the band never crushes the content. Geometry, hit-testing, drag/snap and the drop ghost are unchanged — render-only in src/parts-view.js, with the new _regionBannerH clamp pure added to src/region.js and pinned by tests/region_banner.test.mjs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q3nTpCYNZWLoS7iawjDKN4 Signed-off-by: ChrisBeWithYou <chris@rifflarr.local>
ea77fdd to
cc8df38
Compare
What & why
Christian asked to rework how the Tracks-view region containers look — the old
hairline+spine blocks blended into the lane and read weakly. After a couple of
render passes (A–D, then an A×C hybrid set), the pick was a glass banner:
keep the airy top-lit glass fill so the note silhouette stays the dominant read,
but give each region a proper titled band — and crucially, inset the notes
below the band so they no longer run up under the header line.
What changed
Render-only change to the Tracks (Parts) overview:
stem / green guitar / orange bass / purple drums / ice keys) over a top-lit
glass fill that fades to almost nothing, with a rounded border that accents
and glows when selected.
never cross the header line.
stay inside it.
crushes the content.
Geometry, hit-testing, bar-snap drag and the drop ghost are untouched. The one
new bit of logic — the banner-height clamp
_regionBannerH— lives with theother region-layout pures in
src/region.jsand is pinned by a unit test.Testing
npm test— 304 pass (the 2 pre-existing failures,song_fitandmixer_meter_teardown, fail identically onmain; unrelated to this change).npm run lint— 0 errors.tests/region_banner.test.mjs(banner-height clamp / short-lane guard;fails on
mainwhere_regionBannerHdoesn't exist).the Tracks view on a real pack (AC/DC – Back In Black): banners, centred names,
notes-below-the-header, kind colours, selection glow, and bounded regions all
render correctly.
🤖 Generated with Claude Code