feat(highway-2d): render unpitched slides (slu)#524
Merged
Conversation
The 2D highway drew pitched slides (sl) but ignored unpitched slides (slu) — drawNote read only opts.sl. The 3D highway already renders both (slideTrailEnd). drawNote now draws slu as a dashed diagonal with no arrowhead (no definite target pitch), keeping the solid arrow+arrowhead for pitched sl. The two are mutually exclusive in the data. Chord notes flow through the same drawNote, so chord-note unpitched slides are covered too. Also fixes a latent pre-existing bug flagged in review: `opts?.sl || -1` discarded a pitched slide-to-open (sl: 0); now `?? -1` preserves fret-0 targets and keeps pitched precedence. Codex-reviewed: no P1/P2; dash state reset on all paths, no pitched-slide regression. node --check clean. Closes #336. Part of #334. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2D highway rendered pitched slides (
sl) but ignored unpitched slides (slu) —drawNoteread onlyopts.sl, and there was nosluanywhere instatic/highway.js. The 3D highway already renders both (slideTrailEnd). This brings the 2D highway to parity (the last item in epic #334's render-parity slice).Change
drawNotenow drawssluas a dashed diagonal, no arrowhead (no definite target pitch), keeping the solid arrow + arrowhead for pitchedsl. The two are mutually exclusive in the data; the 3D highway makes the same split.drawNote, so chord-note unpitched slides are covered too.opts?.sl || -1discarded a pitched slide-to-open (sl: 0); now?? -1preserves fret-0 targets and keeps pitched precedence over unpitched.Review
Codex: no P1/P2. Confirmed
setLineDashis reset on all paths (no dash-state leak), no pitched-slide regression. The one P3 (thesl: 0asymmetry) is fixed above.node --checkclean.Render-only; the editor already authors
slu(promptSlideUnpitch).Closes #336. Part of #334.
🤖 Generated with Claude Code