fix(highway): make fret-hand finger (fg) hints hideable, default on (review follow-up to #538) - #539
Merged
Merged
Conversation
Post-merge review of #538 noted the fg finger numeral rendered unconditionally on both highways and couldn't be turned off — only sd/ch sat behind the (default-off) teaching-marks toggle. A user who finds per-note numerals busy had no way to declutter. Add a SEPARATE finger-hints gate that keeps fg shown by default but makes it hideable, independent of the sd/ch opt-in (so the two defaults — fg on, sd/ch off — coexist; a single boolean can't express that): - 2D static/highway.js: _showFingerHints (localStorage 'showFingerHints' !== 'false', i.e. default on), a fingerHintsVisible bundle flag, and get/toggle/setFingerHintsVisible API; gates the fg label. - 3D plugins/highway_3d/screen.js: mirrors via bundle.fingerHintsVisible !== false (default on); gates the fg sprite. sd/ch unchanged. Default-on preserved (absent localStorage / absent bundle flag => shown); only an explicit false hides fg. Codex-reviewed: clean. Render test 7/7. Part of #334. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #538. A post-merge review noted the fret-hand-finger (
fg) numeral rendered unconditionally on both highways with no way to hide it — only thesd/choverlays sat behind the (default-off) teaching-marks toggle. A user who finds per-note numerals busy couldn't declutter.Fix
A separate finger-hints gate, default on but hideable — independent of the
sd/chopt-in so the two defaults (fgon,sd/choff) can coexist (a single boolean can't express that split):static/highway.js—_showFingerHints(localStorageshowFingerHints !== 'false'), afingerHintsVisiblebundle flag, andget/toggle/setFingerHintsVisibleAPI; gates thefglabel.plugins/highway_3d/screen.js— mirrors viabundle.fingerHintsVisible !== false; gates thefgsprite.sd/chbehavior unchanged.Default-on preserved: absent localStorage / absent bundle flag → shown; only an explicit
falsehidesfg.Review / tests
Codex-reviewed: clean.
node tests/js/highway_teaching_marks.test.js7/7; both highwaysnode --checkclean.Part of #334.
🤖 Generated with Claude Code