feat(highway): render caged + guideTones teaching labels (§6.6)#545
Merged
Conversation
byrongamatos
force-pushed
the
feat/template-caged-guidetones-wire
branch
from
June 21, 2026 09:51
914bee7 to
cbb2e6d
Compare
byrongamatos
force-pushed
the
feat/template-caged-guidetones-render
branch
from
June 21, 2026 09:51
d84b254 to
e537cea
Compare
Mirror the voicing/fn.rn teaching-mark render for the two new chord-template
fields, in both the 2D and 3D highways:
- Extend the shared pure chordHarmonyLabels() helper (identical in static/highway.js
and plugins/highway_3d/screen.js) to also surface caged ("CAGED: E") and
guideTones ("gt 4,10"), pre-formatted and node-testable. Invalid caged enum and
out-of-range / non-int guide tones are filtered out.
- Draw both, stacked above the existing rn/voicing labels, in distinct colors.
- Gated behind the SAME teaching-marks toggle (_showTeachingMarks 2D /
teachingMarksVisible 3D) — no clutter on the default highway.
Render only — no scoring / NoteVerifier coupling.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
byrongamatos
force-pushed
the
feat/template-caged-guidetones-render
branch
from
June 21, 2026 09:57
e537cea to
ba77c8c
Compare
byrongamatos
changed the base branch from
feat/template-caged-guidetones-wire
to
main
June 21, 2026 09:57
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #334
Second of three stacked PRs for the deferred FEP #24 pair. Stacked on #544 (base =
feat/template-caged-guidetones-wire) — the renderer can only receive these fields once the wire emits them. Rebase tomainafter #544 merges.What this PR does (2D + 3D render)
Mirrors the
voicing/fn.rnteaching-mark render:chordHarmonyLabels()(identical instatic/highway.jsandplugins/highway_3d/screen.js) extended to also surfacecaged(pre-formatted"CAGED: E") andguideTones("gt 4,10"). Invalid caged enum and out-of-range / non-int guide tones are filtered inside the helper, so formatting stays node-testable.static/highway.js): drawcagedthenguideTonesstacked above the existing rn/voicing labels, distinct colors, reusingfillTextReadable.plugins/highway_3d/screen.js): two more_drawHarmony(...)calls on the same upward stack._showTeachingMarks2D /bundle.teachingMarksVisible3D) — no default-highway clutter.Render only — no scoring / NoteVerifier coupling.
Tests
tests/js/highway_chord_harmony.test.jsextended (same extract-and-eval pattern, run against both the 2D and 3D copies): surfaces caged+guideTones, trims, empties malformed, rejects invalid caged enum, filters out-of-range / non-int guide tones.Verified locally
node tests/js/highway_chord_harmony.test.js→ 10 passed (2D + 3D).node --check static/highway.jsandnode --check plugins/highway_3d/screen.js→ clean.🤖 Generated with Claude Code