fix(onboarding): midi-input multi-provider discovery + home-tour lifecycle - #568
Merged
Conversation
…cycle Addresses Codex review of #526/#528: - midi-input discover(): one provider's enumerate() rejection no longer aborts the whole discovery — other providers (e.g. a native/desktop MIDI provider) are still queried; denial is only reported when NO provider enumerates. - Home tour now waits for a 'v3:dashboard-rendered' event (dashboard.js emits it after the #v3-home innerHTML swap) before attaching Shepherd, instead of a single animation frame that could latch onto pre-render nodes the async dashboard render then replaces. - "Play it now" onboarding now arms the tour (armPendingFirstRun) to run the first time the user returns to v3-home, instead of silently never showing it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex review of #526/#528 (2 iterations on the midi-input part):
discover()no longer aborts on one provider'senumerate()rejection — other providers (e.g. a native/desktop MIDI provider) are still queried, and denial is only reported when NO provider enumerates. A failed provider's now-unverifiable sources are dropped so revoked/unplugged devices don't linger as selectable.v3:dashboard-renderedevent (emitted after the#v3-homeinnerHTML swap) before attaching Shepherd, instead of a single animation frame that could latch onto pre-render nodes the async render then replaces.armPendingFirstRun) to run the first time the user returns to home, instead of silently never showing it.Codex-reviewed clean.