fix(v3): drawer fav-sync honours data-fav-idle (no dim-heart on List View)#717
Merged
Conversation
…View)
_patchCardFav (the Song Details drawer's like -> card heart sync) hardcoded
`classList.toggle('text-white', !fav)`, so toggling the like from the drawer
left List-View rows' `text-fb-textDim` idle class in place — the exact
dim-heart bug #654 fixed for the on-card click handler, reintroduced on the
drawer path. Read the per-heart `data-fav-idle` and swap that class instead,
mirroring wireCards. +regression assertion in v3_favorites_toggle.test.js.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #654 (found while merging the v3-library stack). #703's Song Details drawer syncs a like back to the rendered card via
_patchCardFav, which hardcodedclassList.toggle('text-white', !fav). On a List-View row (idletext-fb-textDim) that leaves the dim class in place, so favoriting from the drawer changes the glyph but the heart stays grey — the same bug #654 fixed for the on-card click handler, on a different code path.Fix: read the heart's
data-fav-idleand swap exactly that class, mirroringwireCards. Adds a regression assertion;v3_favorites_toggle.test.js4/4 green.🤖 Generated with Claude Code