Skip to content

Revert "feat(audio): loopback feeder mode (#865)"#867

Merged
byrongamatos merged 1 commit into
mainfrom
revert/asio-all-app-audio-865
Jul 11, 2026
Merged

Revert "feat(audio): loopback feeder mode (#865)"#867
byrongamatos merged 1 commit into
mainfrom
revert/asio-all-app-audio-865

Conversation

@byrongamatos

@byrongamatos byrongamatos commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Reverts #865 (squash commit 9a58a55) at the maintainer's request. Restores main to the pre-#865 state; the fix/asio-all-app-audio branch is untouched, so #865 can be reopened/re-worked and re-merged later.

Summary by CodeRabbit

  • Bug Fixes
    • Improved audio routing when exclusive output is enabled.
    • Simplified transitions between rendered audio, stems, and audio-element playback.
    • Improved reliability when switching audio sources or replacing the stems graph.
    • Removed unreliable screen-capture-based fallback behavior.

@byrongamatos
byrongamatos merged commit f00ba22 into main Jul 11, 2026
4 checks passed
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f7756b5e-7b08-4cca-8f8d-809d1d40035d

📥 Commits

Reviewing files that changed from the base of the PR and between f09c4a2 and b44116e.

📒 Files selected for processing (2)
  • static/app.js
  • tests/js/renderer_bus_feeder.test.js

📝 Walkthrough

Walkthrough

The renderer bus feeder removes loopback capture and fallback state handling. Exclusive output now selects stems or element capture directly, while tests simplify the sandbox and validate single-call reevaluation paths.

Changes

Renderer bus feeder

Layer / File(s) Summary
Simplify feeder engagement state machine
static/app.js
Element capture stores its long-lived audio objects directly, and feeder reevaluation now engages only stems or element paths without loopback state or fallback handling.
Update feeder test coverage
tests/js/renderer_bus_feeder.test.js
The sandbox no longer provides display-media capture; existing scenarios use single reevaluation calls, and loopback-specific tests are removed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant RendererBusFeeder
  participant StemsOrElementAudio
  participant NativeEngineBus
  RendererBusFeeder->>StemsOrElementAudio: select stems or element source
  RendererBusFeeder->>NativeEngineBus: engage selected audio path
  RendererBusFeeder->>NativeEngineBus: disengage when exclusive output ends
Loading

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert/asio-all-app-audio-865

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant