Revert "feat(audio): loopback feeder mode (#865)"#867
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe renderer bus feeder removes loopback capture and fallback state handling. Exclusive output now selects stems or element capture directly, while tests simplify the sandbox and validate single-call reevaluation paths. ChangesRenderer bus feeder
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant RendererBusFeeder
participant StemsOrElementAudio
participant NativeEngineBus
RendererBusFeeder->>StemsOrElementAudio: select stems or element source
RendererBusFeeder->>NativeEngineBus: engage selected audio path
RendererBusFeeder->>NativeEngineBus: disengage when exclusive output ends
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #865 (squash commit 9a58a55) at the maintainer's request. Restores main to the pre-#865 state; the
fix/asio-all-app-audiobranch is untouched, so #865 can be reopened/re-worked and re-merged later.Summary by CodeRabbit