Skip hidden (dot-prefixed) directories in the library scan#908
Open
riffsmith3 wants to merge 1 commit into
Open
Skip hidden (dot-prefixed) directories in the library scan#908riffsmith3 wants to merge 1 commit into
riffsmith3 wants to merge 1 commit into
Conversation
Skip hidden (dot-prefixed) directories in the library scan
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe library scanner now excludes hidden dot-prefixed directories within the DLC tree, in addition to the existing built-in directories, from sloppak and loose song folder discovery. ChangesLibrary scan filtering
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library scanner descends into hidden (dot-prefixed) directories, so a plugin that keeps an on-disk cache or working files under a
.-prefixed folder in the DLC root has those files indexed as library songs (surfacing as duplicates in the library). This excludes any path with a hidden component below the DLC root, alongside the existingtutorials-builtin/minigames-builtincarve-outs.Summary by CodeRabbit