Skip to content

Skip hidden (dot-prefixed) directories in the library scan#908

Open
riffsmith3 wants to merge 1 commit into
got-feedBack:mainfrom
riffsmith3:hidden_dir
Open

Skip hidden (dot-prefixed) directories in the library scan#908
riffsmith3 wants to merge 1 commit into
got-feedBack:mainfrom
riffsmith3:hidden_dir

Conversation

@riffsmith3

@riffsmith3 riffsmith3 commented Jul 12, 2026

Copy link
Copy Markdown

The library scanner descends into hidden (dot-prefixed) directories, so a plugin that keeps an on-disk cache or working files under a .-prefixed folder in the DLC root has those files indexed as library songs (surfacing as duplicates in the library). This excludes any path with a hidden component below the DLC root, alongside the existing tutorials-builtin / minigames-builtin carve-outs.

Summary by CodeRabbit

  • Bug Fixes
    • Hidden folders within the DLC directory are now excluded from library listings.
    • Built-in tutorial and minigame folders continue to be omitted from scan results.

Skip hidden (dot-prefixed) directories in the library scan
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a5dd8d16-eec4-4b74-8082-d50daf2bd012

📥 Commits

Reviewing files that changed from the base of the PR and between db3ca34 and bedebab.

📒 Files selected for processing (1)
  • lib/scan.py

📝 Walkthrough

Walkthrough

The library scanner now excludes hidden dot-prefixed directories within the DLC tree, in addition to the existing built-in directories, from sloppak and loose song folder discovery.

Changes

Library scan filtering

Layer / File(s) Summary
Exclude hidden DLC directories
lib/scan.py
_is_excluded_from_library now detects dot-prefixed path components relative to the DLC root and excludes those directories from scanning.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: excluding hidden dot-prefixed directories from the library scan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant