Add new builtins to maxInterStageShaderVariables test - #4554
Merged
Conversation
|
Results for build job (at 85f4ba2): -webgpu:api,validation,capability_checks,limits,maxInterStageShaderVariables:createRenderPipeline,at_over:* - 640 cases, 640 subcases (~1/case)
+webgpu:api,validation,capability_checks,limits,maxInterStageShaderVariables:createRenderPipeline,at_over:* - 1880 cases, 1880 subcases (~1/case)
-TOTAL: 284498 cases, 2342682 subcases
+TOTAL: 285738 cases, 2343922 subcases |
greggman
force-pushed
the
maxInterStageShaderVariables
branch
2 times, most recently
from
January 9, 2026 01:40
51b8675 to
c8d7632
Compare
Member
|
It sounds like this renders #4541 obsolete? |
Member
Author
|
Well yea, kind of. Your other PR fixed the test so it counted 1 for each builtin. That pointed out that chrome was only counting one. When I went into the spec and saw 3 others were missing I started adding them but with 6 it felt like it needed a bigger refactor. I guess I missed your newer one. Sorry about that. Which one do you prefer? |
Member
Author
|
Hi Erich, I just wanted to apologize. I totally missed that you had more PRs up for this issue. Feel free to close this PR. |
copybara-service Bot
pushed a commit
to google/dawn
that referenced
this pull request
Jan 9, 2026
The validation for maxInterStageShaderVariables requires checking primitive_index, subgroup_size, and subgroup_invocation_id. With this change chromium passes the latest CTS test: gpuweb/cts#4554 Bug: 474266022,474266023 Fixed: 474266022,474266023 Change-Id: I6a6a6964256b06687781dfb026f982fce83b8bac Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/284055 Commit-Queue: Gregg Tavares <gman@chromium.org> Reviewed-by: James Price <jrprice@google.com>
This was referenced Jan 9, 2026
Closed
kainino0x
reviewed
Jan 10, 2026
kainino0x
added a commit
to kainino0x/cts
that referenced
this pull request
Jan 10, 2026
Co-authored-by: Gregg Tavares <github@greggman.com>
greggman
force-pushed
the
maxInterStageShaderVariables
branch
from
January 10, 2026 00:50
c012822 to
f7b1674
Compare
kainino0x
added a commit
that referenced
this pull request
Jan 13, 2026
…put (#4555) * refactor: lower some vars. in `max_variables_count,input` * fix: correctly count fragment input deductions for built-ins in `max_variables_count,input` * refactor: `max_variables_count,input`: hoist `success` to hidden case param. * proposed refactor * Test primitive-index and subgroups too (taken from #4554) Co-authored-by: Gregg Tavares <github@greggman.com> * add missing enable directives --------- Co-authored-by: Erich Gubler <erichdongubler@gmail.com> Co-authored-by: Gregg Tavares <github@greggman.com>
kainino0x
self-requested a review
January 14, 2026 00:32
kainino0x
approved these changes
Jan 14, 2026
primitive_index, subgroup_id, subgroup_size were missing from the test.
greggman
force-pushed
the
maxInterStageShaderVariables
branch
from
January 14, 2026 17:54
58e63d3 to
85f4ba2
Compare
kainino0x
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
primitive_index, subgroup_id, subgroup_size were missing from the test.
note: Chromium doesn't currently count these. Bugs filed. Also, chromium doesn't currently count correctly for the pre-existing ones. Fixes in progress.
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.