Accept PKCS#1 private keys when using WebCrypto - #135
Draft
danopia wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
PKCS#1PEM files while WebCrypto requiresPKCS#8PEM data,PKCS#8is used as a wrapper forPKCS#1keys,Uint8Array,DataView,atob).I use this function already in a Deno-based library, and wanted to offer it back to this library so that Octokit could benefit from it. I have not tested its behavior with private keys from sources other than Github.
If there is an appetite to bring in this logic then I would appreciate understanding the next steps for this PR. For example I imagine that the
c8 ignorewould be dropped.