IPFS: use IPFS Gateway API#5600
Merged
Merged
Conversation
isum
force-pushed
the
ion/use-ipfs-gateway-api
branch
3 times, most recently
from
60c8b2d to
465e4fc
Compare
isum
force-pushed
the
ion/use-ipfs-gateway-api
branch
2 times, most recently
from
b2f492d to
4c7d7eb
Compare
mangas
reviewed
Sep 19, 2024
| Box::new(self) | ||
| } | ||
|
|
||
| async fn send_test_request(&self) -> anyhow::Result<()> { |
Contributor
There was a problem hiding this comment.
Not sure what this is trying to achieve, is this only used for tests or is this a check for something specific? If it's only used for tests, could it be marked with cfg(test) ?
Member
Author
There was a problem hiding this comment.
Test requests are used to check which type of API a server address supports (RPC or Gateway) in order to initialize the appropriate client.
mangas
approved these changes
Sep 19, 2024
mangas
left a comment
mangas
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall, I think this should be tested in the integration cluster before merging
Introduces a new IPFS gateway client, refactoring the existing RPC API client to reuse the new code. Also introduces some new types and concepts to make working with IPFS easier.
Integrates the new IPFS types and clients into the existing codebase, replacing the old types and client.
isum
force-pushed
the
ion/use-ipfs-gateway-api
branch
from
4c7d7eb to
075abbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new IPFS client that connects and sends requests to the IPFS Gateway. The existing IPFS RPC API client has been refactored to reuse new code.
The
--ipfsCLI argument accepts both IPFS Gateway URLs and RPC API URLs, and the appropriate client is automatically detected and created.Closes #5573
Todos