Skip to content

Fix invalid Automatic-Module-Name - #65

Closed
lkorth wants to merge 1 commit into
graphql-java:masterfrom
lkorth:lkorth-patch-1
Closed

Fix invalid Automatic-Module-Name#65
lkorth wants to merge 1 commit into
graphql-java:masterfrom
lkorth:lkorth-patch-1

Conversation

@lkorth

@lkorth lkorth commented Jun 8, 2022

Copy link
Copy Markdown

- is invalid in the Automatic-Module-Name

Related PRs: graphql-java/java-dataloader#104, graphql-java/graphql-java#2423

Fixes #60

@dondonz

dondonz commented Sep 22, 2022

Copy link
Copy Markdown
Member

Hello, thanks for putting up the PR, I merged in #79 which is very similar, makes the name more consistent with the GraphQL Java name

@dondonz dondonz closed this Sep 22, 2022
@lkorth
lkorth deleted the lkorth-patch-1 branch November 2, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Automatic-Module-Name by replacing dashes with dots to support Java 9+ Module Projects

2 participants