Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Add NetworkSecurityGroupCreate/Set request modules and editor templates so security groups can be created and edited from the TUI instead of just listed. - Delegate ConfirmableRequest through NetworkApiRequest and its resource sub-enums so delete confirmations show the real "Delete Network Security_Group X?" message instead of a generic fallback. - Set loading on delete confirm and clear it after the row is removed, matching the create/update path — previously the table gave no feedback during delete and looked stuck. Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
templates so security groups can be created and edited from the
TUI instead of just listed.
resource sub-enums so delete confirmations show the real
"Delete Network Security_Group X?" message instead of a generic
fallback.
removed, matching the create/update path — previously the table
gave no feedback during delete and looked stuck.
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com