Repository navigation
add gwfgwf exchange func - #581
Conversation
dbrakenhoff
commented
Jul 21, 2026
- add gwfgwf exhange package
- add method to compute exchange data using geopandas from parent and child model datasets.
- add gwfgwf exhange package - add method to compute exchange data using geopandas from parent and child model datasets.
- when index is not explicitly contained within xarray but registered as dim, it acts as range(icell2d). The check_da_dims_coords fails when this is the case. This fixes that. - add test
OnnoEbbens
left a comment
There was a problem hiding this comment.
Just some minor remarks. Also I did not check everything in detail because that would take too much time. How sure are you these functions will work for all cases (rotated grids, vertex/structured grids)? If not I would suggest to add a slight warning that this is still an experimental feature. I leave that up to you
It should work for vertex and structured grids, but there is the requirement that the grids have to align exactly. As long as the grids are built in a similar way, I think it will work fine, but it's not been thoroughly tested. I think it's okay to add it without warnings though. |