Skip to content

add gwfgwf exchange func - #581

Merged
dbrakenhoff merged 6 commits into
devfrom
gwfgwf-exchange-and-nested-example
Aug 27, 2026
Merged

dbrakenhoff merged 6 commits into
devfrom
gwfgwf-exchange-and-nested-example

Conversation

@dbrakenhoff

Copy link
Copy Markdown
Collaborator
  • add gwfgwf exhange package
  • add method to compute exchange data using geopandas from parent and child model datasets.

- add gwfgwf exhange package
- add method to compute exchange data using geopandas from parent and child model datasets.
- when index is not explicitly contained within xarray but registered as dim, it acts as range(icell2d). The check_da_dims_coords fails when this is the case. This fixes that.
- add test

@OnnoEbbens OnnoEbbens left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor remarks. Also I did not check everything in detail because that would take too much time. How sure are you these functions will work for all cases (rotated grids, vertex/structured grids)? If not I would suggest to add a slight warning that this is still an experimental feature. I leave that up to you

Comment thread nlmod/sim/sim.py
Comment thread nlmod/sim/sim.py
@dbrakenhoff
dbrakenhoff requested a review from OnnoEbbens August 27, 2026 10:00
@dbrakenhoff

Copy link
Copy Markdown
Collaborator Author

If not I would suggest to add a slight warning that this is still an experimental feature. I leave that up to you

It should work for vertex and structured grids, but there is the requirement that the grids have to align exactly. As long as the grids are built in a similar way, I think it will work fine, but it's not been thoroughly tested. I think it's okay to add it without warnings though.

@dbrakenhoff
dbrakenhoff merged commit 666cd00 into dev Aug 27, 2026
2 of 3 checks passed
@dbrakenhoff
dbrakenhoff deleted the gwfgwf-exchange-and-nested-example branch August 27, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants