Repository navigation
llama : synchronize before writing the inputs of a reused graph - #217
Open
gaetan-puleo wants to merge 1 commit into
Open
gaetan-puleo wants to merge 1 commit into
gaetan-puleo wants to merge 1 commit into
Conversation
On an integrated GPU the device reads host input buffers in place, so writing them while the previous ubatch is still running is a race. The rebuild path already synchronizes; do the same when the graph is reused.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
llama_context::process_ubatchreuses the previous graph, it callsres->set_inputs()without synchronizing the scheduler. A rebuilt graph synchronizes first (insideggml_backend_sched_alloc_graph/ reset).On an integrated GPU (gfx1151, unified memory), the device reads the host input buffers in place: they are not copied to device memory. So the host can overwrite
inp_pos,inp_tokens, masks, etc. while the previous ubatch's kernels are still reading them. This is a race. It shows up only when graph reuse kicks in (consecutive ubatches with identical topology, e.g. decode).Fix
Call
ggml_backend_sched_synchronize()in the reuse branch before the inputs are written, as the rebuild path already does.Testing
Strix Halo (gfx1151), Qwen3.8 Flash Next Q4_K_XL,
llama-bench -n 128:The decode-speed difference is within noise.